Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add python3.13 support #481

Merged
merged 1 commit into from
Dec 20, 2024
Merged

build: add python3.13 support #481

merged 1 commit into from
Dec 20, 2024

Conversation

vishwa2710
Copy link
Contributor

@vishwa2710 vishwa2710 commented Dec 19, 2024

Summary by CodeRabbit

  • New Features
    • Added support for Python version 3.13 for building bindings.

@vishwa2710 vishwa2710 self-assigned this Dec 19, 2024
Copy link
Contributor

coderabbitai bot commented Dec 19, 2024

Walkthrough

The pull request introduces a modification to the Python bindings' CMakeLists.txt file, specifically updating the list of supported Python versions. The change adds Python 3.13 to the existing list of supported versions (3.9, 3.10, 3.11, 3.12), expanding the project's compatibility with the latest Python release.

Changes

File Change Summary
bindings/python/CMakeLists.txt Updated PYTHON_SEARCH_VERSIONS to include Python 3.13

Poem

🐰 A rabbit's build config delight,
Python 3.13 now takes flight!
CMake lines neatly rearranged,
Versions deftly exchanged,
Compatibility soars with might! 🚀


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
bindings/python/CMakeLists.txt (1)

191-191: Document Python 3.13 support status.

Consider adding a comment above the PYTHON_SEARCH_VERSIONS line to indicate that Python 3.13 support is experimental/alpha, helping users understand the support status.

Here's a suggested addition:

+# Note: Python 3.13 support is experimental as it's still in development
 SET (PYTHON_SEARCH_VERSIONS 3.9 3.10 3.11 3.12 3.13 CACHE STRING "Versions of Python bindings to build.")
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8481615 and 0a9a44b.

📒 Files selected for processing (1)
  • bindings/python/CMakeLists.txt (1 hunks)
🔇 Additional comments (1)
bindings/python/CMakeLists.txt (1)

191-191: Verify pybind11 compatibility with Python 3.13.

The addition of Python 3.13 support looks good. However, since Python 3.13 is still in development (alpha stage), we should verify that pybind11 2.12.0 is compatible with it.

Let's check pybind11's compatibility:

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.21%. Comparing base (8481615) to head (0a9a44b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #481   +/-   ##
=======================================
  Coverage   91.21%   91.21%           
=======================================
  Files          86       86           
  Lines        8720     8720           
=======================================
  Hits         7954     7954           
  Misses        766      766           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucas-bremond lucas-bremond merged commit 911b0ba into main Dec 20, 2024
15 checks passed
@lucas-bremond lucas-bremond deleted the build/python3.13 branch December 20, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants