-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add python3.13 support #481
Conversation
WalkthroughThe pull request introduces a modification to the Python bindings' CMakeLists.txt file, specifically updating the list of supported Python versions. The change adds Python 3.13 to the existing list of supported versions (3.9, 3.10, 3.11, 3.12), expanding the project's compatibility with the latest Python release. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
bindings/python/CMakeLists.txt (1)
191-191
: Document Python 3.13 support status.Consider adding a comment above the
PYTHON_SEARCH_VERSIONS
line to indicate that Python 3.13 support is experimental/alpha, helping users understand the support status.Here's a suggested addition:
+# Note: Python 3.13 support is experimental as it's still in development SET (PYTHON_SEARCH_VERSIONS 3.9 3.10 3.11 3.12 3.13 CACHE STRING "Versions of Python bindings to build.")
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bindings/python/CMakeLists.txt
(1 hunks)
🔇 Additional comments (1)
bindings/python/CMakeLists.txt (1)
191-191
: Verify pybind11 compatibility with Python 3.13.
The addition of Python 3.13 support looks good. However, since Python 3.13 is still in development (alpha stage), we should verify that pybind11 2.12.0 is compatible with it.
Let's check pybind11's compatibility:
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #481 +/- ##
=======================================
Coverage 91.21% 91.21%
=======================================
Files 86 86
Lines 8720 8720
=======================================
Hits 7954 7954
Misses 766 766 ☔ View full report in Codecov by Sentry. |
Summary by CodeRabbit