Skip to content

docs: clean-up Local Orbital Frame comments #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2025
Merged

docs: clean-up Local Orbital Frame comments #487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions include/OpenSpaceToolkit/Astrodynamics/Trajectory/LocalOrbitalFrameTransformProvider.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ class LocalOrbitalFrameTransformProvider : public Provider
NED, ///< North-East-Down (NED) frame
LVLH, ///< Local Vertical, Local Horizontal (LVLH) frame (X axis aligned with position, Z axis aligned with
///< orbital momentum)
VVLH, ///< Vehicle Velocity, Local Horizontal (VVLH) frame (Z axis aligned with opposite of position, Y axis
///< aligned with opposite of orbital momentum)
VVLH, ///< Vehicle Velocity, Local Horizontal (VVLH) frame (Y axis aligned with opposite of orbital momentum,
///< Z axis aligned with opposite of position)
LVLHGD, ///< Local Vertical, Local Horizontal GeoDetic (LVLHGD) frame
QSW, ///< QSW frame (X axis aligned with position, Z axis aligned with orbital momentum)
TNW, ///< Tangent-Normal-Wideband (TNW) frame (X axis aligned with velocity, Z axis aligned with orbital
Expand Down
4 changes: 1 addition & 3 deletions src/OpenSpaceToolkit/Astrodynamics/Trajectory/LocalOrbitalFrameTransformProvider.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,6 @@ Transform LocalOrbitalFrameTransformProvider::generateTransform(
{
// X axis along position vector
// Z axis along orbital momentum
// Y axis toward velocity vector
const Vector3d transformPosition = -aPosition;
const Vector3d transformVelocity = -aVelocity;
const Vector3d xAxis = aPosition.normalized();
Expand All @@ -167,9 +166,8 @@ Transform LocalOrbitalFrameTransformProvider::generateTransform(

case LocalOrbitalFrameTransformProvider::Type::VVLH:
{
// Z axis along negative position vector
// Y axis along negative orbital momentum
// X axis toward velocity vector
// Z axis along negative position vector
const Vector3d transformPosition = -aPosition;
const Vector3d transformVelocity = -aVelocity;
const Vector3d zAxis = -aPosition.normalized();
Expand Down
Loading