Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use absolute path of package #108

Merged
merged 1 commit into from
Jan 15, 2025
Merged

fix: use absolute path of package #108

merged 1 commit into from
Jan 15, 2025

Conversation

alex-liang3
Copy link
Contributor

@alex-liang3 alex-liang3 commented Jan 15, 2025

Paths to the packaged whls are prefixed with /app/, but the --find-links path was missing this, so previously they weren't getting found correctly. This meant that rather installing the bindings built from the previous step, pypi was instead falling back to whatever was on pypi.

This run intentionally introduces an exception to cause the tests to fail, demonstrating that the pipeline is indeed using the locally-built bindings rather than what's available on pypi.

Summary by CodeRabbit

  • Chores
    • Updated Makefile configuration for package installation path
    • Modified CI test Python target to use absolute path for package lookup

@alex-liang3 alex-liang3 self-assigned this Jan 15, 2025
Copy link

coderabbitai bot commented Jan 15, 2025

Walkthrough

The pull request modifies the Makefile, specifically updating the ci-test-python target's package installation path. The change involves transforming a relative path packages/python to an absolute path /app/packages/python for the --find-links option in the pip install command. This modification likely aims to ensure consistent package resolution during the Python testing process.

Changes

File Change Summary
Makefile Updated ci-test-python target's package path from relative to absolute

Possibly related PRs

Suggested reviewers

  • vishwa2710

Poem

🐰 A Makefile Hop of Path Delight

From relative to absolute, a coding flight
Packages dancing with precision bright
A path transformed, no longer tight
CI testing leaps with rabbit might! 🚀


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 521b0f1 and 900f54f.

📒 Files selected for processing (1)
  • Makefile (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Build Development Image / Build Development Image
🔇 Additional comments (1)
Makefile (1)

555-555: LGTM! The absolute path fix ensures reliable package resolution.

The change from relative to absolute path (/app/packages/python) aligns with the Docker container's working directory structure and ensures consistent package resolution during Python testing.

Let's verify path consistency across the Makefile:

✅ Verification successful

Path consistency verified - the absolute path change is correct and consistent

The change aligns with the existing Docker workflow where:

  • The /app/packages/python directory is properly created during build
  • Wheel files are moved to this location
  • The updated pip install command correctly references this absolute path
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for other instances of package paths that might need similar updates
# and verify that the /app/packages/python directory is created correctly.

# Check if other targets use the packages/python path
echo "Checking for other package path usage..."
rg --type make "packages/python" -A 5 -B 5

# Verify the directory creation
echo "Verifying directory creation..."
rg --type make "mkdir.*packages/python" -A 2 -B 2

Length of output: 2333


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.47%. Comparing base (521b0f1) to head (900f54f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #108   +/-   ##
=======================================
  Coverage   69.47%   69.47%           
=======================================
  Files           7        7           
  Lines         498      498           
=======================================
  Hits          346      346           
  Misses        152      152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alex-liang3 alex-liang3 merged commit 1e244df into main Jan 15, 2025
19 checks passed
@alex-liang3 alex-liang3 deleted the fix/packages-path branch January 15, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants