build: prepare for test matrix #164
Conversation
WalkthroughThe pull request introduces a new Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (4)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
Makefile (2)
549-558: Consider adding error handling for missing prerequisites.The target assumes the development image is built and bindings are available, but doesn't verify these prerequisites.
Consider adding checks:
ci-test-python: ## Run Python unit tests. Assumes the dev image has already been built, AND that bindings have been built and are avaliable at `packages/python` + @ if [ ! -d "packages/python" ]; then \ + echo "Error: Python packages not found in packages/python directory"; \ + exit 1; \ + fi + @ echo "Running Python unit tests..." docker run \
555-557: Consider making pandas and plotly optional dependencies.The target installs pandas and plotly packages which might not be required for all tests. Consider making these optional or documenting why they are required.
You could:
- Move these to a separate requirements file
- Make them optional based on a flag
- Document why these packages are needed for the tests
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/build-test.yml(1 hunks)Makefile(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Build Development Image / Build Development Image
🔇 Additional comments (1)
Makefile (1)
545-546: LGTM! Clear documentation of prerequisites.The target's documentation clearly states its assumptions about the development image and the location of bindings.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #164 +/- ##
=======================================
Coverage 75.36% 75.36%
=======================================
Files 56 56
Lines 6426 6426
=======================================
Hits 4843 4843
Misses 1583 1583 ☔ View full report in Codecov by Sentry. |
Adds a new Makefile directive to be used in CI to facilitate unit testing multiple Python versions. This should be merged BEFORE open-space-collective/open-space-toolkit#144, and will only kick in after the latter is merged.
Summary by CodeRabbit