chore: remove unnecessary equals operator, fix tests

open-space-collective · Feb 17, 2024 · e9f5a6f · e9f5a6f
1 parent 590ff26
commit e9f5a6f
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 34 deletions.
diff --git a/include/OpenSpaceToolkit/Physics/Data/Direction.hpp b/include/OpenSpaceToolkit/Physics/Data/Direction.hpp
@@ -34,10 +34,6 @@ class Direction : public Vector
    public:
     Direction(const Vector3d& aValue, const Shared<const Frame>& aFrameSPtr);
 
-    bool operator==(const Direction& aDirection) const;
-
-    bool operator!=(const Direction& aDirection) const;
-
     friend std::ostream& operator<<(std::ostream& anOutputStream, const Vector& aVector);
 
     static Direction Undefined();

diff --git a/src/OpenSpaceToolkit/Physics/Data/Direction.cpp b/src/OpenSpaceToolkit/Physics/Data/Direction.cpp
@@ -27,21 +27,6 @@ Direction::Direction(const Vector3d& aValue, const Shared<const Frame>& aFrameSP
     }
 }
 
-bool Direction::operator==(const Direction& aDirection) const
-{
-    if ((!this->isDefined()) || (!aDirection.isDefined()))
-    {
-        return false;
-    }
-
-    return Vector::operator==(aDirection);
-}
-
-bool Direction::operator!=(const Direction& aDirection) const
-{
-    return !((*this) == aDirection);
-}
-
 std::ostream& operator<<(std::ostream& anOutputStream, const Direction& aDirection)
 {
     ostk::core::utils::Print::Header(anOutputStream, "Direction");

diff --git a/test/OpenSpaceToolkit/Physics/Data/Direction.test.cpp b/test/OpenSpaceToolkit/Physics/Data/Direction.test.cpp
@@ -15,28 +15,14 @@ using ostk::physics::coordinate::Frame;
 class OpenSpaceToolkit_Physics_Data_Direction : public ::testing::Test
 {
    protected:
-    const Vector3d value_ = {1.0, 2.0, 3.0};
+    const Vector3d value_ = {1.0, 0.0, 0.0};
     const Shared<const Frame> frameSPtr_ = Frame::GCRF();
     const Direction direction_ = {
         value_,
         frameSPtr_,
     };
 };
 
-TEST_F(OpenSpaceToolkit_Physics_Data_Direction, EqualToOperator)
-{
-    {
-        EXPECT_TRUE(direction_ == direction_);
-    }
-}
-
-TEST_F(OpenSpaceToolkit_Physics_Data_Direction, NotEqualToOperator)
-{
-    {
-        EXPECT_FALSE(direction_ != direction_);
-    }
-}
-
 TEST_F(OpenSpaceToolkit_Physics_Data_Direction, StreamOperator)
 {
     {