Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add OSTK_PHYSICS_DATA_LOCAL_REPOSITORY environment setting to set all at once #181

Merged
merged 6 commits into from
Nov 6, 2023

Conversation

kyle-cochran
Copy link
Contributor

When installing OSTk into a new environment, if the default data files path isn't to your liking, you have to set 7 environment variable to make sure all of the data are put into the correct place. This is a bit annoying and causes problem when new data are added to physics, because users do not know to add the new settings.

This adds a single configuration env var called OSTK_PHYSICS_DATA_LOCAL_REPOSITORY that let's you set the location for all data at once. The original environment variable are still available and override this one.

Addresses: #179

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #181 (a45f3e3) into main (931cf74) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #181   +/-   ##
=======================================
  Coverage   79.87%   79.87%           
=======================================
  Files          93       93           
  Lines        7448     7460   +12     
=======================================
+ Hits         5949     5959   +10     
- Misses       1499     1501    +2     
Files Coverage Δ
...hysics/Coordinate/Frame/Providers/IERS/Manager.cpp 75.35% <100.00%> (-0.15%) ⬇️
src/OpenSpaceToolkit/Physics/Data/Manager.cpp 78.14% <100.00%> (-0.38%) ⬇️
.../Physics/Environment/Atmospheric/Earth/Manager.cpp 87.54% <100.00%> (-0.28%) ⬇️
.../Physics/Environment/Ephemerides/SPICE/Manager.cpp 86.66% <100.00%> (+1.43%) ⬆️
...hysics/Environment/Gravitational/Earth/Manager.cpp 83.11% <100.00%> (-0.44%) ⬇️
...kit/Physics/Environment/Magnetic/Earth/Manager.cpp 83.64% <100.00%> (-0.43%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Contributor

@apaletta3 apaletta3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Epic kyle! Great idea!

@kyle-cochran kyle-cochran self-assigned this Nov 2, 2023
@kyle-cochran kyle-cochran enabled auto-merge (squash) November 6, 2023 18:21
@kyle-cochran kyle-cochran merged commit cd66f0b into main Nov 6, 2023
11 checks passed
@kyle-cochran kyle-cochran deleted the users/kyle/unified-local-repo-settign branch November 6, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants