Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: rename abbreviated namespaces to full pathing for Core/IO/Math #191

Closed

Conversation

vishwa2710
Copy link
Contributor

No description provided.

@vishwa2710 vishwa2710 self-assigned this Nov 22, 2023
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (73e4b63) 79.64% compared to head (2b03c29) 79.64%.

Files Patch % Lines
...c/OpenSpaceToolkit/Physics/Units/Derived/Angle.cpp 53.84% 6 Missing ⚠️
...t/Physics/Environment/Ephemerides/SPICE/Kernel.cpp 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #191   +/-   ##
=======================================
  Coverage   79.64%   79.64%           
=======================================
  Files          96       96           
  Lines        7521     7521           
=======================================
  Hits         5990     5990           
  Misses       1531     1531           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucas-bremond
Copy link
Contributor

This should be a refactor! no?

@vishwa2710
Copy link
Contributor Author

Absolutely it should!
I always forget about the ! :'(

@vishwa2710 vishwa2710 changed the title refactor: rename abbreviated namespaces to full pathing for Core/IO/Math refactor!: rename abbreviated namespaces to full pathing for Core/IO/Math Nov 22, 2023
@vishwa2710 vishwa2710 closed this Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants