Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump Core/IO/Math to 1.0 and use explicit namespacing #192

Merged
merged 4 commits into from
Nov 27, 2023

Conversation

kyle-cochran
Copy link
Contributor

@kyle-cochran kyle-cochran commented Nov 26, 2023

Math: obj->object, geom->geometry, trf::rot->transformations::rotations
Core: fs->filesystem

Draft pending release of OSTk Math with trf::rot renaming

@kyle-cochran kyle-cochran self-assigned this Nov 26, 2023
@kyle-cochran kyle-cochran removed the request for review from vishwa2710 November 26, 2023 21:04
Copy link

codecov bot commented Nov 26, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (73e4b63) 79.64% compared to head (83a994c) 79.64%.

Files Patch % Lines
...c/OpenSpaceToolkit/Physics/Units/Derived/Angle.cpp 53.84% 6 Missing ⚠️
...t/Physics/Environment/Ephemerides/SPICE/Kernel.cpp 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #192   +/-   ##
=======================================
  Coverage   79.64%   79.64%           
=======================================
  Files          96       96           
  Lines        7521     7521           
=======================================
  Hits         5990     5990           
  Misses       1531     1531           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyle-cochran kyle-cochran changed the title build: bump Core/Physics/Math to 1.0 and use explicit namespacing build: bump Core/IO/Math to 1.0 and use explicit namespacing Nov 26, 2023
@kyle-cochran kyle-cochran changed the title build: bump Core/IO/Math to 1.0 and use explicit namespacing draft: build: bump Core/IO/Math to 1.0 and use explicit namespacing Nov 26, 2023
Copy link
Contributor

@apaletta3 apaletta3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@kyle-cochran kyle-cochran changed the title draft: build: bump Core/IO/Math to 1.0 and use explicit namespacing build: bump Core/IO/Math to 1.0 and use explicit namespacing Nov 27, 2023
@kyle-cochran kyle-cochran merged commit 77f4c72 into main Nov 27, 2023
@kyle-cochran kyle-cochran deleted the users/kyle/explicit-namespacing branch November 27, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants