Skip to content

refactor: remove pybound methods from Celestial that aren't usable in python #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2024
Merged

refactor: remove pybound methods from Celestial that aren't usable in python #205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions bindings/python/src/OpenSpaceToolkitPhysicsPy/Environment/Object/Celestial.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,12 @@ inline void OpenSpaceToolkitPhysicsPy_Environment_Object_Celestial(pybind11::mod
.def("get_position_in", &Celestial::getPositionIn, arg("frame"), arg("instant"))
.def("get_transform_to", &Celestial::getTransformTo, arg("frame"), arg("instant"))
.def("get_axes_in", &Celestial::getAxesIn, arg("frame"), arg("instant"))
.def("get_gravitational_field_at", &Celestial::getGravitationalFieldAt, arg("position"), arg("instant"))
.def("get_magnetic_field_at", &Celestial::getMagneticFieldAt, arg("position"), arg("instant"))
.def("get_atmospheric_density_at", &Celestial::getAtmosphericDensityAt, arg("position"), arg("instant"))

// TBI: whenenver data::Vector and data::Scalar is supported in Python
// .def("get_gravitational_field_at", &Celestial::getGravitationalFieldAt, arg("position"), arg("instant"))
// .def("get_magnetic_field_at", &Celestial::getMagneticFieldAt, arg("position"), arg("instant"))
// .def("get_atmospheric_density_at", &Celestial::getAtmosphericDensityAt, arg("position"), arg("instant"))

.def("gravitational_model_is_defined", &Celestial::gravitationalModelIsDefined)
.def("magnetic_model_is_defined", &Celestial::magneticModelIsDefined)
.def("atmospheric_model_is_defined", &Celestial::atmosphericModelIsDefined)
Expand Down Expand Up @@ -147,7 +150,6 @@ inline void OpenSpaceToolkitPhysicsPy_Environment_Object_Celestial(pybind11::mod
// Create "celestial" python submodule
auto celestial = aModule.def_submodule("celestial");


// Add objects to python "celestial" submodules
OpenSpaceToolkitPhysicsPy_Environment_Object_Celestial_Earth(celestial);
OpenSpaceToolkitPhysicsPy_Environment_Object_Celestial_Moon(celestial);
Expand Down
10 changes: 1 addition & 9 deletions test/OpenSpaceToolkit/Physics/Environment/Object/Celestial.test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,15 +70,7 @@ using EarthAtmosphericModel = ostk::physics::environment::atmospheric::Earth;

// TEST (OpenSpaceToolkit_Physics_Environment_Object_Celestial, Constructor)
// {

// using ostk::physics::environment::Object ;

// {

// FAIL() ;

// }

// TBM: Constructor tested below, but should be refactored to this test case directly
// }

TEST(OpenSpaceToolkit_Physics_Environment_Object_Celestial, accessModel)
Expand Down