Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bindings for physics data classes #210

Merged
merged 6 commits into from
Feb 24, 2024
Merged

feat: bindings for physics data classes #210

merged 6 commits into from
Feb 24, 2024

Conversation

vishwa2710
Copy link
Contributor

No description provided.

@vishwa2710 vishwa2710 requested a review from apaletta3 February 17, 2024 10:47
@vishwa2710 vishwa2710 self-assigned this Feb 17, 2024
@vishwa2710 vishwa2710 marked this pull request as draft February 17, 2024 10:47
@codecov Codecov
Copy link

codecov bot commented Feb 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.60%. Comparing base (4e0768b) to head (5b4909b).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #210   +/-   ##
=======================================
  Coverage   79.60%   79.60%           
=======================================
  Files          96       96           
  Lines        7542     7542           
=======================================
  Hits         6004     6004           
  Misses       1538     1538

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vishwa2710 vishwa2710 force-pushed the feat/add-physics-data-bindings branch from 9572816 to b5c0d26 Compare February 20, 2024 01:51
@vishwa2710 vishwa2710 marked this pull request as ready for review February 20, 2024 01:51
apaletta3
apaletta3 approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@apaletta3 apaletta3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just approve the nits if you agree :)

bindings/python/src/OpenSpaceToolkitPhysicsPy/Data/Direction.cpp Outdated Show resolved Hide resolved
bindings/python/src/OpenSpaceToolkitPhysicsPy/Unit.cpp Show resolved Hide resolved
bindings/python/test/data/test_direction.py Show resolved Hide resolved
bindings/python/test/data/test_scalar.py Show resolved Hide resolved
bindings/python/test/data/test_scalar.py Show resolved Hide resolved
bindings/python/test/data/test_vector.py Show resolved Hide resolved
bindings/python/test/data/test_vector.py Show resolved Hide resolved
@apaletta3 apaletta3 force-pushed the feat/add-physics-data-bindings branch from b5c0d26 to 79ea8e9 Compare February 23, 2024 13:13
@vishwa2710 @apaletta3
Apply suggestions from code review
5b4909b 
Co-authored-by: Antoine Paletta <98616558+apaletta3@users.noreply.github.com>
@vishwa2710 vishwa2710 merged commit 3753f34 into main Feb 24, 2024
11 checks passed
@vishwa2710 vishwa2710 deleted the feat/add-physics-data-bindings branch February 24, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apaletta3 apaletta3 apaletta3 approved these changes

Assignees

@vishwa2710 vishwa2710

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vishwa2710 @apaletta3