-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: stubs breaking mypy #319
Conversation
WalkthroughThe pull request introduces several modifications across Python bindings and test files. The changes primarily focus on refining import statements, updating type annotations, and improving stub file generation. In the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #319 +/- ##
=======================================
Coverage 82.89% 82.89%
=======================================
Files 102 102
Lines 8033 8033
=======================================
Hits 6659 6659
Misses 1374 1374 ☔ View full report in Codecov by Sentry. |
For context, see
ostk.physics.Unit
- namely, the "None unit type" entry in theType
enum has been changed:Unit.Type.None
->Unit.Type.None_
This isn't expect to affect anything, as the former definition isn't valid in Python anyway.
Summary by CodeRabbit
Release Notes
Bug Fixes
Refactor
Chores