feat: force C++17 build for aarch64

[tapiab]

This PR forces aarch64 build to C++17

Summary by CodeRabbit

• New Features

  • Enhanced CMake configuration to support C++17 based on additional system conditions.

• Bug Fixes

  • Improved logic for determining C++ standard support, ensuring better compatibility across different systems.

[coderabbitai]

Walkthrough

The changes in this pull request modify the CMake configuration for the OpenSpaceToolkitSimulation project. The update alters the logic for enabling C++ standard support by introducing an additional condition that checks for the "aarch64" processor architecture. If either the BUILD_WITH_CXX_17 option is true or the processor matches "aarch64", C++17 support is enabled. If neither condition is satisfied, the configuration defaults to C++20 support.

Changes

File	Change Summary
CMakeLists.txt	Modified logic for enabling C++ standard support based on BUILD_WITH_CXX_17 and processor architecture "aarch64". Defaults to C++20 if neither condition is met.

Poem

In the land of code where rabbits play,
C++17 hops in, brightening the day.
With checks for "aarch64" in sight,
Our builds now gleam with newfound light.
So let’s code and compile, with joy we’ll sing,
For every change, a new spring! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

CMakeLists.txt (1)

Line range hint 138-160: Approved: C++17 enforced for aarch64, but consider long-term implications

The change successfully enforces C++17 for aarch64 processors while maintaining C++20 for other architectures, aligning with the PR objective. However, this introduces an architecture-dependent C++ standard selection, which may lead to subtle differences in behavior across platforms.

Recommendations:

1. Document this architecture-specific behavior in the project documentation.
2. Consider if this is a temporary solution or if there's a plan to standardize the C++ version across all architectures in the future.
3. Ensure thorough testing on both aarch64 and other architectures to catch any potential issues arising from the different C++ standards.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 6593d8d and 66e3f8b.

📒 Files selected for processing (1)

• CMakeLists.txt (1 hunks)

🧰 Additional context used

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.84%. Comparing base (6593d8d) to head (66e3f8b).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #61   +/-   ##
=======================================
  Coverage   51.84%   51.84%           
=======================================
  Files           8        8           
  Lines         461      461           
=======================================
  Hits          239      239           
  Misses        222      222           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.