Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signature to UpdateContent #301

Merged

Conversation

BinaryFissionGames
Copy link
Contributor

@BinaryFissionGames BinaryFissionGames commented Sep 25, 2024

Passes the signature field to UpdateContent, so the implementation may verify the signature of the file.

Closes #300

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.84%. Comparing base (b33ab76) to head (e807750).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #301      +/-   ##
==========================================
- Coverage   77.96%   77.84%   -0.13%     
==========================================
  Files          25       25              
  Lines        1743     1747       +4     
==========================================
+ Hits         1359     1360       +1     
- Misses        281      283       +2     
- Partials      103      104       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BinaryFissionGames BinaryFissionGames marked this pull request as ready for review September 25, 2024 16:28
@BinaryFissionGames BinaryFissionGames requested a review from a team as a code owner September 25, 2024 16:28
Copy link
Contributor

@andykellr andykellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@andykellr andykellr merged commit ad53170 into open-telemetry:main Sep 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PackageSyncer should verify the signature somehow
3 participants