Allow setting initial heartbeat interval #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #305 +/- ##
==========================================
+ Coverage 77.20% 77.24% +0.03%
==========================================
Files 25 25
Lines 2299 2303 +4
==========================================
+ Hits 1775 1779 +4
Misses 420 420
Partials 104 104 ☔ View full report in Codecov by Sentry. |
| } else { | ||
| assert.Never(t, func() bool { | ||
| return msgCount.Load() >= 2 | ||
| }, 50*time.Millisecond, 10*time.Millisecond) |
There was a problem hiding this comment.
This has a chance of failing to catch an unexpected heartbeat if the heartbeat is delayed, but I think that's fine.
tigrannajaryan
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
HeartbeatIntervalSecondoption toStartSettingsto allow setting initial heartbeat interval.resolve #303