-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Commit
**Description:** This enables `goleak` checks for all packages whose only failure is due to [a known issue](census-instrumentation/opencensus-go#1191) within the `opencensus-go` package. I believe it's safe to ignore for two main reasons: 1. All references that I'm aware of are indirect, the contrib repo isn't directly using the stat's worker functionality. The goroutine is started in the dependency's `init()` so it's not something that we're causing. 2. We're actively moving away from the opencensus dependency, and hope to remove it entirely soon. Relevant issue: open-telemetry/opentelemetry-collector#816. Once this work is complete the ignore will no longer be necessary and we can safely remove it. The only changes in this PR are test related. The same file is being copied into different packages, and then we run `make gotidy`. No functionality has been changed. **Link to tracking Issue:** #30438
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
// Copyright The OpenTelemetry Authors | ||
// SPDX-License-Identifier: Apache-2.0 | ||
|
||
package cfgmetadatagen | ||
|
||
import ( | ||
"testing" | ||
|
||
"go.uber.org/goleak" | ||
) | ||
|
||
// The IgnoreTopFunction call prevents catching the leak generated by opencensus | ||
// defaultWorker.Start which at this time is part of the package's init call. | ||
// See https://github.com/census-instrumentation/opencensus-go/issues/1191 for more information. | ||
func TestMain(m *testing.M) { | ||
goleak.VerifyTestMain(m, goleak.IgnoreTopFunction("go.opencensus.io/stats/view.(*worker).start")) | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
// Copyright The OpenTelemetry Authors | ||
// SPDX-License-Identifier: Apache-2.0 | ||
|
||
package metadata | ||
|
||
import ( | ||
"testing" | ||
|
||
"go.uber.org/goleak" | ||
) | ||
|
||
// The IgnoreTopFunction call prevents catching the leak generated by opencensus | ||
// defaultWorker.Start which at this time is part of the package's init call. | ||
// See https://github.com/census-instrumentation/opencensus-go/issues/1191 for more information. | ||
func TestMain(m *testing.M) { | ||
goleak.VerifyTestMain(m, goleak.IgnoreTopFunction("go.opencensus.io/stats/view.(*worker).start")) | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
// Copyright The OpenTelemetry Authors | ||
// SPDX-License-Identifier: Apache-2.0 | ||
|
||
package countconnector | ||
|
||
import ( | ||
"testing" | ||
|
||
"go.uber.org/goleak" | ||
) | ||
|
||
// The IgnoreTopFunction call prevents catching the leak generated by opencensus | ||
// defaultWorker.Start which at this time is part of the package's init call. | ||
// See https://github.com/census-instrumentation/opencensus-go/issues/1191 for more information. | ||
func TestMain(m *testing.M) { | ||
goleak.VerifyTestMain(m, goleak.IgnoreTopFunction("go.opencensus.io/stats/view.(*worker).start")) | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
// Copyright The OpenTelemetry Authors | ||
// SPDX-License-Identifier: Apache-2.0 | ||
|
||
package exceptionsconnector | ||
|
||
import ( | ||
"testing" | ||
|
||
"go.uber.org/goleak" | ||
) | ||
|
||
// The IgnoreTopFunction call prevents catching the leak generated by opencensus | ||
// defaultWorker.Start which at this time is part of the package's init call. | ||
// See https://github.com/census-instrumentation/opencensus-go/issues/1191 for more information. | ||
func TestMain(m *testing.M) { | ||
goleak.VerifyTestMain(m, goleak.IgnoreTopFunction("go.opencensus.io/stats/view.(*worker).start")) | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
// Copyright The OpenTelemetry Authors | ||
// SPDX-License-Identifier: Apache-2.0 | ||
|
||
package failoverconnector | ||
|
||
import ( | ||
"testing" | ||
|
||
"go.uber.org/goleak" | ||
) | ||
|
||
// The IgnoreTopFunction call prevents catching the leak generated by opencensus | ||
// defaultWorker.Start which at this time is part of the package's init call. | ||
// See https://github.com/census-instrumentation/opencensus-go/issues/1191 for more information. | ||
func TestMain(m *testing.M) { | ||
goleak.VerifyTestMain(m, goleak.IgnoreTopFunction("go.opencensus.io/stats/view.(*worker).start")) | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
// Copyright The OpenTelemetry Authors | ||
// SPDX-License-Identifier: Apache-2.0 | ||
|
||
package routingconnector | ||
|
||
import ( | ||
"testing" | ||
|
||
"go.uber.org/goleak" | ||
) | ||
|
||
// The IgnoreTopFunction call prevents catching the leak generated by opencensus | ||
// defaultWorker.Start which at this time is part of the package's init call. | ||
// See https://github.com/census-instrumentation/opencensus-go/issues/1191 for more information. | ||
func TestMain(m *testing.M) { | ||
goleak.VerifyTestMain(m, goleak.IgnoreTopFunction("go.opencensus.io/stats/view.(*worker).start")) | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
// Copyright The OpenTelemetry Authors | ||
// SPDX-License-Identifier: Apache-2.0 | ||
|
||
package servicegraphconnector | ||
|
||
import ( | ||
"testing" | ||
|
||
"go.uber.org/goleak" | ||
) | ||
|
||
// The IgnoreTopFunction call prevents catching the leak generated by opencensus | ||
// defaultWorker.Start which at this time is part of the package's init call. | ||
// See https://github.com/census-instrumentation/opencensus-go/issues/1191 for more information. | ||
func TestMain(m *testing.M) { | ||
goleak.VerifyTestMain(m, goleak.IgnoreTopFunction("go.opencensus.io/stats/view.(*worker).start")) | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
// Copyright The OpenTelemetry Authors | ||
// SPDX-License-Identifier: Apache-2.0 | ||
|
||
package spanmetricsconnector | ||
|
||
import ( | ||
"testing" | ||
|
||
"go.uber.org/goleak" | ||
) | ||
|
||
// The IgnoreTopFunction call prevents catching the leak generated by opencensus | ||
// defaultWorker.Start which at this time is part of the package's init call. | ||
// See https://github.com/census-instrumentation/opencensus-go/issues/1191 for more information. | ||
func TestMain(m *testing.M) { | ||
goleak.VerifyTestMain(m, goleak.IgnoreTopFunction("go.opencensus.io/stats/view.(*worker).start")) | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
// Copyright The OpenTelemetry Authors | ||
// SPDX-License-Identifier: Apache-2.0 | ||
|
||
package awskinesisexporter | ||
|
||
import ( | ||
"testing" | ||
|
||
"go.uber.org/goleak" | ||
) | ||
|
||
// The IgnoreTopFunction call prevents catching the leak generated by opencensus | ||
// defaultWorker.Start which at this time is part of the package's init call. | ||
// See https://github.com/census-instrumentation/opencensus-go/issues/1191 for more information. | ||
func TestMain(m *testing.M) { | ||
goleak.VerifyTestMain(m, goleak.IgnoreTopFunction("go.opencensus.io/stats/view.(*worker).start")) | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
// Copyright The OpenTelemetry Authors | ||
// SPDX-License-Identifier: Apache-2.0 | ||
|
||
package carbonexporter | ||
|
||
import ( | ||
"testing" | ||
|
||
"go.uber.org/goleak" | ||
) | ||
|
||
// The IgnoreTopFunction call prevents catching the leak generated by opencensus | ||
// defaultWorker.Start which at this time is part of the package's init call. | ||
// See https://github.com/census-instrumentation/opencensus-go/issues/1191 for more information. | ||
func TestMain(m *testing.M) { | ||
goleak.VerifyTestMain(m, goleak.IgnoreTopFunction("go.opencensus.io/stats/view.(*worker).start")) | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
// Copyright The OpenTelemetry Authors | ||
// SPDX-License-Identifier: Apache-2.0 | ||
|
||
package cassandraexporter | ||
|
||
import ( | ||
"testing" | ||
|
||
"go.uber.org/goleak" | ||
) | ||
|
||
// The IgnoreTopFunction call prevents catching the leak generated by opencensus | ||
// defaultWorker.Start which at this time is part of the package's init call. | ||
// See https://github.com/census-instrumentation/opencensus-go/issues/1191 for more information. | ||
func TestMain(m *testing.M) { | ||
goleak.VerifyTestMain(m, goleak.IgnoreTopFunction("go.opencensus.io/stats/view.(*worker).start")) | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
// Copyright The OpenTelemetry Authors | ||
// SPDX-License-Identifier: Apache-2.0 | ||
|
||
package clickhouseexporter | ||
|
||
import ( | ||
"testing" | ||
|
||
"go.uber.org/goleak" | ||
) | ||
|
||
// The IgnoreTopFunction call prevents catching the leak generated by opencensus | ||
// defaultWorker.Start which at this time is part of the package's init call. | ||
// See https://github.com/census-instrumentation/opencensus-go/issues/1191 for more information. | ||
func TestMain(m *testing.M) { | ||
goleak.VerifyTestMain(m, goleak.IgnoreTopFunction("go.opencensus.io/stats/view.(*worker).start")) | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
// Copyright The OpenTelemetry Authors | ||
// SPDX-License-Identifier: Apache-2.0 | ||
|
||
package clientutil | ||
|
||
import ( | ||
"testing" | ||
|
||
"go.uber.org/goleak" | ||
) | ||
|
||
// The IgnoreTopFunction call prevents catching the leak generated by opencensus | ||
// defaultWorker.Start which at this time is part of the package's init call. | ||
// See https://github.com/census-instrumentation/opencensus-go/issues/1191 for more information. | ||
func TestMain(m *testing.M) { | ||
goleak.VerifyTestMain(m, goleak.IgnoreTopFunction("go.opencensus.io/stats/view.(*worker).start")) | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
// Copyright The OpenTelemetry Authors | ||
// SPDX-License-Identifier: Apache-2.0 | ||
|
||
package logs | ||
|
||
import ( | ||
"testing" | ||
|
||
"go.uber.org/goleak" | ||
) | ||
|
||
// The IgnoreTopFunction call prevents catching the leak generated by opencensus | ||
// defaultWorker.Start which at this time is part of the package's init call. | ||
// See https://github.com/census-instrumentation/opencensus-go/issues/1191 for more information. | ||
func TestMain(m *testing.M) { | ||
goleak.VerifyTestMain(m, goleak.IgnoreTopFunction("go.opencensus.io/stats/view.(*worker).start")) | ||
} |