Skip to content

Commit

Permalink
addressed previous PR comments
Browse files Browse the repository at this point in the history 
Signed-off-by: Samiur Arif <samiur.arif@sumologic.com>
  • Loading branch information
@samiura
samiura committed Jan 28, 2025
1 parent f1ffe2a commit 35288a1
Show file tree
Hide file tree
Showing 10 changed files with 130 additions and 135 deletions.
14 changes: 0 additions & 14 deletions receiver/vcenterreceiver/documentation.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -834,20 +834,6 @@ Total time that the CPU spent in an idle state.
| ---- | ----------- | ------ |
| object | The object on the virtual machine or host that is being reported on. | Any Str |
### vcenter.vm.cpu.latency.avg
Percent of time the virtual machine is unable to run because it is contending for access to the physical CPU.
| Unit | Metric Type | Value Type |
| ---- | ----------- | ---------- |
| ms | Gauge | Int |
#### Attributes
| Name | Description | Values |
| ---- | ----------- | ------ |
| object | The object on the virtual machine or host that is being reported on. | Any Str |
### vcenter.vm.cpu.ready.time
Milliseconds of CPU time spent in ready state.
Expand Down
4 changes: 0 additions & 4 deletions receiver/vcenterreceiver/internal/metadata/generated_config.go
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions receiver/vcenterreceiver/internal/metadata/generated_config_test.go
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

59 changes: 0 additions & 59 deletions receiver/vcenterreceiver/internal/metadata/generated_metrics.go
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 0 additions & 18 deletions receiver/vcenterreceiver/internal/metadata/generated_metrics_test.go
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 0 additions & 4 deletions receiver/vcenterreceiver/internal/metadata/testdata/config.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,6 @@ all_set:
enabled: true
vcenter.vm.cpu.idle.time:
enabled: true
vcenter.vm.cpu.latency.avg:
enabled: true
vcenter.vm.cpu.readiness:
enabled: true
vcenter.vm.cpu.ready.time:
Expand Down Expand Up @@ -272,8 +270,6 @@ none_set:
enabled: false
vcenter.vm.cpu.idle.time:
enabled: false
vcenter.vm.cpu.latency.avg:
enabled: false
vcenter.vm.cpu.readiness:
enabled: false
vcenter.vm.cpu.ready.time:
Expand Down
63 changes: 53 additions & 10 deletions receiver/vcenterreceiver/internal/mockserver/responses/vm-performance-counters.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -85,13 +85,27 @@
</id>
<value>70</value>
</value>
<value xsi:type="PerfMetricIntSeries">
<id>
<counterId>534</counterId>
<instance></instance>
</id>
<value>90</value>
</value>
<value xsi:type="PerfMetricIntSeries">
<id>
<counterId>535</counterId>
<instance></instance>
</id>
<value>90</value>
</value>
<value xsi:type="PerfMetricIntSeries">
<id>
<counterId>536</counterId>
<instance></instance>
</id>
<value>90</value>
</value>
<value xsi:type="PerfMetricIntSeries">
<id>
<counterId>143</counterId>
Expand Down Expand Up @@ -399,7 +413,7 @@
<instance>4000</instance>
</id>
<value>70</value>
</value>
</value>
<value xsi:type="PerfMetricIntSeries">
<id>
<counterId>535</counterId>
Expand Down Expand Up @@ -440,21 +454,21 @@
<counterId>13</counterId>
<instance>4000</instance>
</id>
<value>1899</value>
<value>2</value>
</value>
<value xsi:type="PerfMetricIntSeries">
<id>
<counterId>11</counterId>
<instance>4000</instance>
</id>
<value>2899</value>
<value>3</value>
</value>
<value xsi:type="PerfMetricIntSeries">
<id>
<counterId>12</counterId>
<instance>4000</instance>
</id>
<value>3899</value>
<value>5</value>
</value>
</returnval>
<returnval xsi:type="PerfEntityMetric">
Expand Down Expand Up @@ -540,13 +554,27 @@
</id>
<value>70</value>
</value>
<value xsi:type="PerfMetricIntSeries">
<id>
<counterId>534</counterId>
<instance></instance>
</id>
<value>70</value>
</value>
<value xsi:type="PerfMetricIntSeries">
<id>
<counterId>535</counterId>
<instance></instance>
</id>
<value>20</value>
</value>
<value xsi:type="PerfMetricIntSeries">
<id>
<counterId>536</counterId>
<instance></instance>
</id>
<value>70</value>
</value>
<value xsi:type="PerfMetricIntSeries">
<id>
<counterId>143</counterId>
Expand Down Expand Up @@ -785,6 +813,7 @@
</id>
<value>90</value>
</value>

<value xsi:type="PerfMetricIntSeries">
<id>
<counterId>532</counterId>
Expand Down Expand Up @@ -895,21 +924,21 @@
<counterId>13</counterId>
<instance>4000</instance>
</id>
<value>1899</value>
<value>2</value>
</value>
<value xsi:type="PerfMetricIntSeries">
<id>
<counterId>11</counterId>
<instance>4000</instance>
</id>
<value>2899</value>
<value>3</value>
</value>
<value xsi:type="PerfMetricIntSeries">
<id>
<counterId>12</counterId>
<instance>4000</instance>
</id>
<value>3899</value>
<value>5</value>
</value>
</returnval>
<returnval xsi:type="PerfEntityMetric">
Expand Down Expand Up @@ -1317,13 +1346,27 @@
</id>
<value>70</value>
</value>
<value xsi:type="PerfMetricIntSeries">
<id>
<counterId>534</counterId>
<instance>4000</instance>
</id>
<value>70</value>
</value>
<value xsi:type="PerfMetricIntSeries">
<id>
<counterId>535</counterId>
<instance>4000</instance>
</id>
<value>90</value>
</value>
<value xsi:type="PerfMetricIntSeries">
<id>
<counterId>536</counterId>
<instance>4000</instance>
</id>
<value>70</value>
</value>
<value xsi:type="PerfMetricIntSeries">
<id>
<counterId>530</counterId>
Expand All @@ -1350,21 +1393,21 @@
<counterId>13</counterId>
<instance>4000</instance>
</id>
<value>1899</value>
<value>2</value>
</value>
<value xsi:type="PerfMetricIntSeries">
<id>
<counterId>11</counterId>
<instance>4000</instance>
</id>
<value>2899</value>
<value>3</value>
</value>
<value xsi:type="PerfMetricIntSeries">
<id>
<counterId>12</counterId>
<instance>4000</instance>
</id>
<value>4899</value>
<value>5</value>
</value>
</returnval>
</QueryPerfResponse>
Expand Down
9 changes: 1 addition & 8 deletions receiver/vcenterreceiver/metadata.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ metrics:
unit: "{congestions/s}"
gauge:
value_type: double
attributes: []
attributes: []
vcenter.datastore.disk.usage:
enabled: true
description: The amount of space in the datastore.
Expand Down Expand Up @@ -589,13 +589,6 @@ metrics:
gauge:
value_type: int
attributes: [object_name]
vcenter.vm.cpu.latency.avg:
enabled: false
description: Percent of time the virtual machine is unable to run because it is contending for access to the physical CPU.
unit: ms
gauge:
value_type: int
attributes: [object_name]
vcenter.vm.memory.ballooned:
enabled: true
description: The amount of memory that is ballooned due to virtualization.
Expand Down
Loading

0 comments on commit 35288a1

Please sign in to comment.