Skip to content

Commit

Permalink
Add explicit TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
mx-psi committed Jan 24, 2025
1 parent 4016d9f commit 4df4f3b
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions internal/otelarrow/netstats/netstats_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ func dropView(instrument metric.Instrument) metric.View {
)
}

// TODO: This will be exposed by each component. Remove this function and use
// the publicly exposed view once this is possible to do.
func viewsFromLevel(level configtelemetry.Level) []metric.View {
var views []metric.View

Expand Down Expand Up @@ -57,10 +59,6 @@ func viewsFromLevel(level configtelemetry.Level) []metric.View {
)
}

// contrib's internal/otelarrow/netstats metrics
// See
// - https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/a25f05/internal/otelarrow/netstats/netstats.go#L130
// - https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/a25f05/internal/otelarrow/netstats/netstats.go#L165
if level < configtelemetry.LevelDetailed {
scope := instrumentation.Scope{Name: scopeName}
// Compressed size metrics.
Expand Down

0 comments on commit 4df4f3b

Please sign in to comment.