Replace dots with underscores based on Entity SIG discussion

open-telemetry · Dec 18, 2024 · 7cb96f9 · 7cb96f9
1 parent 260fe9b
commit 7cb96f9
Show file tree

Hide file tree

Showing 8 changed files with 68 additions and 68 deletions.
diff --git a/processor/resourcedetectionprocessor/internal/gcp/documentation.md b/processor/resourcedetectionprocessor/internal/gcp/documentation.md
@@ -19,11 +19,11 @@
 | faas.version | The faas.version | Any Str | true |
 | gcp.cloud_run.job.execution | The Job execution name | Any Str | true |
 | gcp.cloud_run.job.task_index | The Job execution task index | Any Str | true |
-| gcp.gce.instance.group.manager.name | The name of an instanceGroupManager. | Any Str | true |
-| gcp.gce.instance.group.manager.region | The region of a regional instanceGroupManager. | Any Str | true |
-| gcp.gce.instance.group.manager.zone | The zone of a zonal instanceGroupManager. | Any Str | true |
 | gcp.gce.instance.hostname | The hostname of the GCE instance. | Any Str | false |
 | gcp.gce.instance.name | The name of the GCE instance. | Any Str | false |
+| gcp.gce.instance_group_manager.name | The name of an instanceGroupManager. | Any Str | true |
+| gcp.gce.instance_group_manager.region | The region of a regional instanceGroupManager. | Any Str | true |
+| gcp.gce.instance_group_manager.zone | The zone of a zonal instanceGroupManager. | Any Str | true |
 | host.id | The host.id | Any Str | true |
 | host.name | The host.name | Any Str | true |
 | host.type | The host.type | Any Str | true |

diff --git a/processor/resourcedetectionprocessor/internal/gcp/gcp_test.go b/processor/resourcedetectionprocessor/internal/gcp/gcp_test.go
@@ -168,8 +168,8 @@ func TestDetect(t *testing.T) {
 				conventions.AttributeHostType:              "n1-standard1",
 				conventions.AttributeCloudRegion:           "us-central1",
 				conventions.AttributeCloudAvailabilityZone: "us-central1-c",
-				"gcp.gce.instance.group.manager.name":      "my-gke-node",
-				"gcp.gce.instance.group.manager.region":    "us-central1",
+				"gcp.gce.instance_group_manager.name":      "my-gke-node",
+				"gcp.gce.instance_group_manager.region":    "us-central1",
 			},
 		},
 		{

diff --git a/processor/resourcedetectionprocessor/internal/gcp/internal/metadata/generated_config.go b/processor/resourcedetectionprocessor/internal/gcp/internal/metadata/generated_config.go
diff --git a/processor/resourcedetectionprocessor/internal/gcp/internal/metadata/generated_config_test.go b/processor/resourcedetectionprocessor/internal/gcp/internal/metadata/generated_config_test.go
diff --git a/processor/resourcedetectionprocessor/internal/gcp/internal/metadata/generated_resource.go b/processor/resourcedetectionprocessor/internal/gcp/internal/metadata/generated_resource.go
diff --git a/...ssor/resourcedetectionprocessor/internal/gcp/internal/metadata/generated_resource_test.go b/...ssor/resourcedetectionprocessor/internal/gcp/internal/metadata/generated_resource_test.go
diff --git a/processor/resourcedetectionprocessor/internal/gcp/internal/metadata/testdata/config.yaml b/processor/resourcedetectionprocessor/internal/gcp/internal/metadata/testdata/config.yaml
@@ -23,15 +23,15 @@ all_set:
       enabled: true
     gcp.cloud_run.job.task_index:
       enabled: true
-    gcp.gce.instance.group.manager.name:
+    gcp.gce.instance.hostname:
       enabled: true
-    gcp.gce.instance.group.manager.region:
+    gcp.gce.instance.name:
       enabled: true
-    gcp.gce.instance.group.manager.zone:
+    gcp.gce.instance_group_manager.name:
       enabled: true
-    gcp.gce.instance.hostname:
+    gcp.gce.instance_group_manager.region:
       enabled: true
-    gcp.gce.instance.name:
+    gcp.gce.instance_group_manager.zone:
       enabled: true
     host.id:
       enabled: true
@@ -65,15 +65,15 @@ none_set:
       enabled: false
     gcp.cloud_run.job.task_index:
       enabled: false
-    gcp.gce.instance.group.manager.name:
+    gcp.gce.instance.hostname:
       enabled: false
-    gcp.gce.instance.group.manager.region:
+    gcp.gce.instance.name:
       enabled: false
-    gcp.gce.instance.group.manager.zone:
+    gcp.gce.instance_group_manager.name:
       enabled: false
-    gcp.gce.instance.hostname:
+    gcp.gce.instance_group_manager.region:
       enabled: false
-    gcp.gce.instance.name:
+    gcp.gce.instance_group_manager.zone:
       enabled: false
     host.id:
       enabled: false

diff --git a/processor/resourcedetectionprocessor/internal/gcp/metadata.yaml b/processor/resourcedetectionprocessor/internal/gcp/metadata.yaml
@@ -71,15 +71,15 @@ resource_attributes:
     description: The hostname of the GCE instance.
     type: string
     enabled: false
-  gcp.gce.instance.group.manager.name:
+  gcp.gce.instance_group_manager.name:
     description: The name of an instanceGroupManager.
     type: string
     enabled: true
-  gcp.gce.instance.group.manager.zone:
+  gcp.gce.instance_group_manager.zone:
     description: The zone of a zonal instanceGroupManager.
     type: string
     enabled: true
-  gcp.gce.instance.group.manager.region:
+  gcp.gce.instance_group_manager.region:
     description: The region of a regional instanceGroupManager.
     type: string
     enabled: true