-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/vcenter] Additional metrics for vCenter receiver #33607
Labels
Comments
BominRahmani
added
enhancement
New feature or request
needs triage
New item requiring triage
labels
Jun 18, 2024
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Removing |
This was referenced Jun 19, 2024
djaglowski
pushed a commit
that referenced
this issue
Jul 1, 2024
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> This PR adds the `vcenter.vm.cpu.readiness` metric. More information on this metric can be found [here](https://vdc-repo.vmware.com/vmwb-repository/dcr-public/d1902b0e-d479-46bf-8ac9-cee0e31e8ec0/07ce8dbd-db48-4261-9b8f-c6d3ad8ba472/vim.vm.Summary.QuickStats.html). **Link to tracking Issue:** #33607 **Testing:** <Describe what testing was performed and which tests were added.> The metric was scraped from a test vCenter environment, and golden test files were updated to reflect the addition of the metric. **Documentation:** <Describe the documentation added.> Documentation was updated according to the metadata.yaml
djaglowski
pushed a commit
that referenced
this issue
Jul 1, 2024
…pacity) (#33646) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> The following PR adds the following metrics ``` vcenter.host.network.packet.drop.rate vcenter.host.cpu.capacity vcenter.host.cpu.reserve.capacity ``` These metrics can be found in the following links respectively: [errorTx and errorRx](https://vdc-repo.vmware.com/vmwb-repository/dcr-public/d1902b0e-d479-46bf-8ac9-cee0e31e8ec0/07ce8dbd-db48-4261-9b8f-c6d3ad8ba472/network_counters.html) [reservedCapacity and totalCapacity](https://vdc-repo.vmware.com/vmwb-repository/dcr-public/d1902b0e-d479-46bf-8ac9-cee0e31e8ec0/07ce8dbd-db48-4261-9b8f-c6d3ad8ba472/cpu_counters.html) **Link to tracking Issue:** #33607 **Testing:** <Describe what testing was performed and which tests were added.> Tested against a live environment to scrape added metrics, and updated golden test files. **Documentation:** <Describe the documentation added.> Updated documentation through mdatagen.
djaglowski
pushed a commit
that referenced
this issue
Jul 9, 2024
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> The following PR adds these [metrics](https://vdc-repo.vmware.com/vmwb-repository/dcr-public/d1902b0e-d479-46bf-8ac9-cee0e31e8ec0/07ce8dbd-db48-4261-9b8f-c6d3ad8ba472/vim.ResourcePool.Summary.QuickStats.html) ``` - vcenter.resource_pool.memory.swapped - vcenter.resource_pool.memory.ballooned - vcenter.resource_pool.memory.granted {memory_granted: shared / private} ``` It also adds the attribute `memory_usage_type` and splits up the `vcenter.resource_pool.memory.usage` metric into the following attributes: `host, guest, overhead` **Link to tracking Issue:** #33607 **Testing:** <Describe what testing was performed and which tests were added.> Golden files were generated to show the addition of the new metrics. **Documentation:** Documentation generated by `make generate`.
djaglowski
pushed a commit
that referenced
this issue
Jul 10, 2024
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> The following PR introduces multiple different metrics at a datacenter level. It takes advantage of processing thats already done at the cluster, host, vm, and datastore level in order to aggregate datacenter level metrics. ``` - vcenter.datacenter.cluster.count status={red/green/yellow, gray} - vcenter.datacenter.vm.count status={red/green/yellow, gray} power_state={on/off/suspended} - vcenter.datacenter.datastore.count status={red/green/yellow, gray} - vcenter.datacenter.host.count status={red/green/yellow, gray} power_state={on/off/standby/unknown} - vcenter.datacenter.disk.space disk_state={used/available} - vcenter.datacenter.cpu.limit - vcenter.datacenter.memory.limit ``` **Link to tracking Issue:** #33607 **Testing:** <Describe what testing was performed and which tests were added.> Tested against a live environment to make sure all values matched up. Golden testing files have been updated. **Documentation:** <Describe the documentation added.> All documentation was generated through mdatagen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Component(s)
receiver/vcenter
Is your feature request related to a problem? Please describe.
There are various metrics that we don't currently capture or could capture at a higher level.
Describe the solution you'd like
These metrics can most aptly be categorized under three categories:
Datacenter
Some of these proposed metrics may resemble existing ones, such as
vcenter.datacenter.vm.count
, which is similar to the currently capturedvcenter.cluster.vm.count
. However, the proposed metric aggregates through these alongside other vm's that may exist outside a cluster level. In effect providing a total/aggregated look into how many vms exist under that datacenter.Host
Resource pool
Virtual machine
If approved, I can split these enhancements out into 4 separate PR's.
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: