-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[receiver/vcenter] Adds Datacenter metrics #33933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
djaglowski
merged 15 commits into
open-telemetry:main
from
BominRahmani:feat/add-vcenter-datacenter-metrics
Jul 10, 2024
Merged
[receiver/vcenter] Adds Datacenter metrics #33933
djaglowski
merged 15 commits into
open-telemetry:main
from
BominRahmani:feat/add-vcenter-datacenter-metrics
Jul 10, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanKurek
suggested changes
Jul 9, 2024
e1a0bcc
to
230f661
Compare
StefanKurek
suggested changes
Jul 9, 2024
StefanKurek
reviewed
Jul 9, 2024
1a90d81
to
68a780d
Compare
StefanKurek
suggested changes
Jul 9, 2024
StefanKurek
reviewed
Jul 9, 2024
StefanKurek
reviewed
Jul 10, 2024
StefanKurek
reviewed
Jul 10, 2024
StefanKurek
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment needs to be removed, but otherwise looks good
djaglowski
reviewed
Jul 10, 2024
djaglowski
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The following PR introduces multiple different metrics at a datacenter level. It takes advantage of processing thats already done at the cluster, host, vm, and datastore level in order to aggregate datacenter level metrics.
Link to tracking Issue: #33607
Testing:
Tested against a live environment to make sure all values matched up.
Golden testing files have been updated.
Documentation:
All documentation was generated through mdatagen