Skip to content

[receiver/vcenter] Adds Datacenter metrics #33933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

BominRahmani
Copy link
Contributor

@BominRahmani BominRahmani commented Jul 7, 2024

Description:

The following PR introduces multiple different metrics at a datacenter level. It takes advantage of processing thats already done at the cluster, host, vm, and datastore level in order to aggregate datacenter level metrics.

- vcenter.datacenter.cluster.count                 status={red/green/yellow, gray}
- vcenter.datacenter.vm.count                      status={red/green/yellow, gray} power_state={on/off/suspended}
- vcenter.datacenter.datastore.count               status={red/green/yellow, gray}
- vcenter.datacenter.host.count                    status={red/green/yellow, gray} power_state={on/off/standby/unknown}
- vcenter.datacenter.disk.space                    disk_state={used/available}
- vcenter.datacenter.cpu.limit
- vcenter.datacenter.memory.limit

Link to tracking Issue: #33607

Testing:
Tested against a live environment to make sure all values matched up.
Golden testing files have been updated.

Documentation:
All documentation was generated through mdatagen

@BominRahmani BominRahmani force-pushed the feat/add-vcenter-datacenter-metrics branch from e1a0bcc to 230f661 Compare July 9, 2024 18:06
@github-actions github-actions bot added the cmd/otelcontribcol otelcontribcol command label Jul 9, 2024
@BominRahmani BominRahmani force-pushed the feat/add-vcenter-datacenter-metrics branch from 1a90d81 to 68a780d Compare July 9, 2024 18:09
Copy link
Contributor

@StefanKurek StefanKurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment needs to be removed, but otherwise looks good

@BominRahmani BominRahmani marked this pull request as ready for review July 10, 2024 17:00
@BominRahmani BominRahmani requested a review from a team July 10, 2024 17:00
@BominRahmani BominRahmani requested a review from djaglowski July 10, 2024 20:15
@djaglowski djaglowski merged commit 5b290f0 into open-telemetry:main Jul 10, 2024
154 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants