[receiver/kafkareceiver] Add Azure Resource Logs Support #23333
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cparkins
requested review from
MovieStoreGuy,
atoulme and
djaglowski
as code owners
cparkins
force-pushed
the
receiver/kafka-receiver/add-azure-resource-log-support
branch
from
cc1d473 to
d0dbc06
Compare
|
Please sign the CLA |
I have. I rebased to use the correct email address. |
github-actions
bot
added
cmd/configschema
mx-psi
reviewed
Jun 14, 2023
cparkins
force-pushed
the
receiver/kafka-receiver/add-azure-resource-log-support
branch
3 times, most recently
from
911621a to
2f56bea
Compare
|
@atoulme we would need your review here since you will be added as a codeowner |
cparkins
force-pushed
the
receiver/kafka-receiver/add-azure-resource-log-support
branch
from
e2c7ff2 to
9cf3da6
Compare
cparkins
force-pushed
the
receiver/kafka-receiver/add-azure-resource-log-support
branch
from
29d9b3c to
f177c8a
Compare
martinjt
reviewed
Jul 11, 2023
| return l, err | ||
| } | ||
|
|
||
| // The Azure resource ID will be pulled into a common resource attribute. |
There was a problem hiding this comment.
I don't think this assumption is incorrect, I've seen the batch contain multiple resource IDs before.
There was a problem hiding this comment.
I added code to handle that situation.
cparkins
force-pushed
the
receiver/kafka-receiver/add-azure-resource-log-support
branch
3 times, most recently
from
c7d558a to
3066415
Compare
cparkins
force-pushed
the
receiver/kafka-receiver/add-azure-resource-log-support
branch
from
3066415 to
81e27ff
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
…(pkg/translators/azure) and use shared format in Event Hub and Kafka Receivers.
cparkins
force-pushed
the
receiver/kafka-receiver/add-azure-resource-log-support
branch
from
81e27ff to
d05f11d
Compare
MovieStoreGuy
requested changes
Aug 6, 2023
|
@MovieStoreGuy I just created this PR for the Translator portion #25096 |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
cparkins
deleted the
receiver/kafka-receiver/add-azure-resource-log-support
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add the ability to Consume Azure Resource Logs in the Kaka Receiver.
Link to tracking Issue:
#18210
Testing:
Locally tested by receiving data from Azure Event Hubs with the Kafka Receiver. Data was coming from Azure Resources using Diagnostic Settings.
Documentation:
Documentation updated to reflect new format.