Kinetica exporter/pr 2 metrics #27239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
am-kinetica
force-pushed
the
kinetica-exporter/PR-2-metrics
branch
from
562f03b to
85eb91d
Compare
…m-kinetica/opentelemetry-collector-contrib into kinetica-exporter/PR-2-metrics
|
Merged with changes from main |
TylerHelmuth
added
the
Skip Changelog
…m-kinetica/opentelemetry-collector-contrib into kinetica-exporter/PR-2-metrics
TylerHelmuth
removed
the
Skip Changelog
TylerHelmuth
reviewed
Oct 3, 2023
atoulme
approved these changes
Nov 29, 2023
|
I think this PR looks good now. @TylerHelmuth mind taking another look? |
TylerHelmuth
requested changes
Nov 29, 2023
There was a problem hiding this comment.
@atoulme we're waiting on some unit tests for metrics_exporter.go.
…m-kinetica/opentelemetry-collector-contrib into kinetica-exporter/PR-2-metrics
TylerHelmuth
reviewed
Jan 9, 2024
There was a problem hiding this comment.
@am-kinetica wanted to chime in an say I'm still keeping an eye on this PR, excited to see the progress made on the unit tests.
TylerHelmuth
approved these changes
Jan 9, 2024
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jan 10, 2024
**Description:** Added metrics handling **Link to tracking Issue:** open-telemetry#24294 **Testing:** No new tests **Documentation:** No new documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Added metrics handling
Link to tracking Issue: #24294
Testing: No new tests
Documentation: No new documentation