Initial contribution of remote tap extension #27477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
atoulme
added
Accepted Component
atoulme
force-pushed
the
remoteobserverextension_initial
branch
from
ada122a to
7ea1f0c
Compare
atoulme
force-pushed
the
remoteobserverextension_initial
branch
3 times, most recently
from
a6cbee3 to
dd415ce
Compare
|
Since there are already observer extensions that have differing functionality, would naming this "websocket extension" and migrating the "websocket processor" to a different package name make sense? Excited for this component to be added. |
|
Discussed in SIG meeting that indeed observer is already taken, we should take up a new name. "tap" was proposed. |
atoulme
force-pushed
the
remoteobserverextension_initial
branch
2 times, most recently
from
2ef681c to
2941d67
Compare
atoulme
changed the title
yurishkuro
reviewed
Oct 20, 2023
atoulme
force-pushed
the
remoteobserverextension_initial
branch
from
2edf3f4 to
9cbba10
Compare
What tests are missing? |
atoulme
force-pushed
the
remoteobserverextension_initial
branch
2 times, most recently
from
a9c6791 to
762783f
Compare
atoulme
force-pushed
the
remoteobserverextension_initial
branch
from
762783f to
3849952
Compare
|
@MovieStoreGuy let me know what else I should cover. It should be good to go here, bear in mind this is just a first PR to set the skeleton of the component, and we'll have more chats afterwards. |
atoulme
force-pushed
the
remoteobserverextension_initial
branch
from
3849952 to
2a65ab2
Compare
MovieStoreGuy
approved these changes
Oct 28, 2023
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
**Description:** Adds the basis of a new extension, the remote ~observer~ tap extension, to be used to display the contents of the data observed via remote observer processors. This PR deals only with the structure and required files related to the extension. **Link to tracking Issue:** open-telemetry#19634 **Testing:** N/A **Documentation:** README --------- Co-authored-by: Pablo Collins <pcollins@splunk.com>
RoryCrispin
pushed a commit
to ClickHouse/opentelemetry-collector-contrib
that referenced
this pull request
Nov 24, 2023
**Description:** Adds the basis of a new extension, the remote ~observer~ tap extension, to be used to display the contents of the data observed via remote observer processors. This PR deals only with the structure and required files related to the extension. **Link to tracking Issue:** open-telemetry#19634 **Testing:** N/A **Documentation:** README --------- Co-authored-by: Pablo Collins <pcollins@splunk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds the basis of a new extension, the remote
observertap extension, to be used to display the contents of the data observed via remote observer processors.This PR deals only with the structure and required files related to the extension.
Link to tracking Issue:
#19634
Testing:
N/A
Documentation:
README