[receiver/splunkhec] Fix the double encoding of JSON responses #27606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatsheep9146
approved these changes
Oct 11, 2023
dmitryax
reviewed
Oct 16, 2023
atoulme
added
the
ready to merge
|
@dmitryax I made changes per your request, can we merge this? |
dmitryax
approved these changes
Oct 27, 2023
sigilioso
pushed a commit
to carlossscastro/opentelemetry-collector-contrib
that referenced
this pull request
Oct 27, 2023
…telemetry#27606) **Description:** We would double-encode JSON objects as strings. We typically have encoded strings as JSON strings as static responses to issues encountered during data processing. Along the way, we adopted JSON objects to match the Splunk Enterprise API. However, we didn't stop encoding as JSON strings, resulting in double encoded JSON strings. **Link to tracking Issue:** Fixes open-telemetry#27604 **Testing:** Unit test changes.
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…telemetry#27606) **Description:** We would double-encode JSON objects as strings. We typically have encoded strings as JSON strings as static responses to issues encountered during data processing. Along the way, we adopted JSON objects to match the Splunk Enterprise API. However, we didn't stop encoding as JSON strings, resulting in double encoded JSON strings. **Link to tracking Issue:** Fixes open-telemetry#27604 **Testing:** Unit test changes.
RoryCrispin
pushed a commit
to ClickHouse/opentelemetry-collector-contrib
that referenced
this pull request
Nov 24, 2023
…telemetry#27606) **Description:** We would double-encode JSON objects as strings. We typically have encoded strings as JSON strings as static responses to issues encountered during data processing. Along the way, we adopted JSON objects to match the Splunk Enterprise API. However, we didn't stop encoding as JSON strings, resulting in double encoded JSON strings. **Link to tracking Issue:** Fixes open-telemetry#27604 **Testing:** Unit test changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We would double-encode JSON objects as strings. We typically have encoded strings as JSON strings as static responses to issues encountered during data processing. Along the way, we adopted JSON objects to match the Splunk Enterprise API. However, we didn't stop encoding as JSON strings, resulting in double encoded JSON strings.
Link to tracking Issue:
Fixes #27604
Testing:
Unit test changes.