-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] make the collector module version script output a git diff #27898
Conversation
This will allow possibly users down the road to perform this task on their laptop with a make target, so they can easily fix this type of issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes senes to me, but I wouldn't mind if @codeboten or @djaglowski since i know they have spent some time setting up the CI.
FYI: on a mac, the following error message shows when I run the command:
This is because sed in macos is slightly different https://stackoverflow.com/questions/19456518/error-when-using-sed-with-find-command-on-os-x-invalid-command-code |
I can fix it to make it work on Mac, IIRC when I did that it broke on Linux. I'll keep trying. |
…pen-telemetry#27898) The current behavior consists in exiting early on the first difference found. This approach continues to look at all changes, and only exits after outputting a git diff of all the changes.
…pen-telemetry#27898) The current behavior consists in exiting early on the first difference found. This approach continues to look at all changes, and only exits after outputting a git diff of all the changes.
…pen-telemetry#27898) The current behavior consists in exiting early on the first difference found. This approach continues to look at all changes, and only exits after outputting a git diff of all the changes.
The current behavior consists in exiting early on the first difference found.
This approach continues to look at all changes, and only exits after outputting a git diff of all the changes.