[processor/remotetap] Change default endpoint from :12001 to localhost:12001
#30806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
previously approved these changes
Jan 29, 2024
|
The rationale was that we could skip it because of it being alpha #30702 (comment). I am fine with adding the feature gate instead |
|
@mx-psi there are other alpha components for which we used the feature gate, see https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/30826/files I'd go the route of the feature gate to be consistent |
|
Closing as this approach is abandoned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Change default endpoint from
:12001tolocalhost:12001Link to tracking Issue:
#30702
Documentation:
Changed README