Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(otelarrowreceiver): Upstream Otel-Arrow Receiver with v0.23.0 changes #32990

Conversation

moh-osman3
Copy link
Contributor

Description:
This change branches off of @jmacd's original PR #32972 to also add in documentation for changes I was responsible for.

The OTel-Arrow receiver had in-flight changes while the component was being introduced in #32015.

This change brings the receiver component in this repository up to v0.23.0.

Link to tracking Issue:
#26491

Testing:
New tests copied from the otel-arrow repo.

Documentation:
Added to the readme descriptions of the new config options that users can take advantage of.

@moh-osman3 moh-osman3 marked this pull request as ready for review May 10, 2024 20:20
@moh-osman3 moh-osman3 requested review from a team and crobert-1 May 10, 2024 20:20
Copy link
Contributor

@jmacd jmacd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @moh-osman3

)

// NewFactory creates a new OTel-Arrow receiver factory.
// NewFactory creates a new OTLP receiver factory.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might be an incorrect revert

@jmacd
Copy link
Contributor

jmacd commented May 20, 2024

We will re-open this for two reasons: (1) we've discovered a possible regression in this update, which bears more investigation, (2) we need to back-port all changes to avoid spurious diffs.

@jmacd jmacd closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants