[chore] update loki exporter to use telemetry builder #33098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
reviewed
May 16, 2024
bogdandrutu
approved these changes
May 16, 2024
TylerHelmuth
approved these changes
May 17, 2024
This uses the new mdatagen functionality to define all internal telemetry for a component in metadata.yaml for ease of discovery, consistency across components, and in the near future simplify testing of telemetry produced by components. Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
codeboten
force-pushed
the
codeboten/loki-use-mdatagen-metrics
branch
from
ebf44d8 to
57953ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the new mdatagen functionality to define all internal telemetry for a component in metadata.yaml for ease of discovery, consistency across components, and in the near future simplify testing of telemetry produced by components.