[receiver/vcenter] Fixes Client Virtual App Call Error When No Virtual Apps #33102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanKurek
force-pushed
the
fix/vcenterreceiver-errors-on-empty-vApps
branch
from
348d848 to
d12e4d8
Compare
djaglowski
reviewed
May 16, 2024
djaglowski
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Virtual Apps might not exist in an environment. Currently a
NotFounderror for the internal client is thrown when this condition occurs. I modified this to simply return an empty array, because this should simply mean that it did not find any Virtual Apps. I also added more client unit tests to test for these types of conditions.Link to tracking Issue:
#33073 (loosely tied to this. At the very least this issue made me discover this problem)
Testing:
Added new unit tests which showed the error. Fix caused the new unit test to pass.
Documentation:
N/A