[receiver/googlepubsub] fix span and trace id parsing crash #33247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexvanboxel
force-pushed
the
cloud_log_enhance
branch
3 times, most recently
from
071c7af to
5628c2f
Compare
tiffany76
reviewed
May 30, 2024
Thank you |
Co-authored-by: Tiffany Hrabusa <30397949+tiffany76@users.noreply.github.com>
alexvanboxel
force-pushed
the
cloud_log_enhance
branch
from
25a09d3 to
61c9e96
Compare
|
Rebase against, main (but... it's impossible to keep up). For the approvers : I am the CODEOWNER of this receiver |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
|
Could we please reopen this in order to move forward with closing #33400 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixed a crash in the span and trace ID parsing when encountering corrupt data. Enhanced the
cloud_loggingparsing so it's better testable and includes additional tests. Made the code read for options in the parsing json/protoPayload (implementation not included).Includes minor fixes in the README.
Link to tracking Issue:
#32007
Testing:
Added additional tests for the bug (trace and span id), but also for several of the other mappings.
Documentation:
The documentation now also includes all of the mappings the receiver does in
cloud_loggingmode.