Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][processor/tailsampling] Refactor tests #33509

Merged

Conversation

jpkrohling
Copy link
Member

This PR starts a refactoring of the tests for the tail-sampling processor. Following this, I'll add a couple of extra benchmarks, preparing for a deeper refactoring of the main code.

Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de

@jpkrohling jpkrohling requested review from a team and TylerHelmuth June 12, 2024 11:16
@github-actions github-actions bot added the processor/tailsampling Tail sampling processor label Jun 12, 2024
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@jpkrohling jpkrohling force-pushed the jpkrohling/refactor-tests-tsp branch from 8e184f7 to 19277ab Compare June 12, 2024 11:17
@jpkrohling jpkrohling requested a review from jamesmoessis June 12, 2024 11:20
@jpkrohling
Copy link
Member Author

@jamesmoessis, this is the first refactoring of the tests that I mentioned via Slack. Once this is done, I'll create a benchmark or two, preparing ourselves for the decision cache and further improvements of the processor itself.

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@jpkrohling jpkrohling merged commit 5821671 into open-telemetry:main Jun 12, 2024
145 of 162 checks passed
@github-actions github-actions bot added this to the next release milestone Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
processor/tailsampling Tail sampling processor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants