Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add line number option for filelogreceiver #33530

Merged
merged 23 commits into from
Jun 17, 2024
Merged

add line number option for filelogreceiver #33530

merged 23 commits into from
Jun 17, 2024

Conversation

sfc-gh-jikim
Copy link
Contributor

Description: Adding an option to include line numbers as a record attribute to the filelogreceiver.

Testing: Add unit tests

Documentation: Add documentation on filelogreceiver for the new file line number option

@sfc-gh-jikim sfc-gh-jikim requested a review from djaglowski as a code owner June 12, 2024 23:16
@sfc-gh-jikim sfc-gh-jikim requested a review from a team June 12, 2024 23:16
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jun 12, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@bogdandrutu
Copy link
Member

Please make sure CLA is valid. We usually do not review PRs until then.

@sfc-gh-jikim sfc-gh-jikim requested a review from djaglowski June 13, 2024 18:16
bogdandrutu
bogdandrutu approved these changes Jun 13, 2024
View reviewed changes
pkg/stanza/fileconsumer/attrs/attrs.go Outdated Show resolved Hide resolved
@sfc-gh-jikim sfc-gh-jikim requested a review from djaglowski June 14, 2024 16:54
@djaglowski djaglowski merged commit 2f079f9 into open-telemetry:main Jun 17, 2024
154 checks passed
@github-actions github-actions bot added this to the next release milestone Jun 17, 2024
@francois07 francois07 mentioned this pull request Jul 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djaglowski djaglowski djaglowski approved these changes

@bogdandrutu bogdandrutu bogdandrutu approved these changes

Assignees

@songy23 songy23

Labels
pkg/stanza receiver/filelog
Projects
None yet
Milestone
v0.103.0
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-jikim @bogdandrutu @djaglowski @songy23