Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/fileexporter] Add support for profiles signal #36007

Merged

Conversation

haoqixu
Copy link
Member

@haoqixu haoqixu commented Oct 26, 2024

Description

Add support for profiles signal to fileexporter

Link to tracking issue

Fixes #35978

@atoulme
Copy link
Contributor

atoulme commented Oct 29, 2024

Please add a changelog.

@haoqixu
Copy link
Member Author

haoqixu commented Oct 31, 2024

This PR requires #36008 to pass the tests. Waiting for that.

@haoqixu
Copy link
Member Author

haoqixu commented Oct 31, 2024

There are some // TODOs to update internal/coreinternal/testdata and add tests. I will update this PR later.

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

Copy link
Contributor

github-actions bot commented Dec 6, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Dec 6, 2024
@haoqixu haoqixu force-pushed the f-profiles-fileexporter branch from b621d71 to cb30921 Compare December 6, 2024 08:21
@github-actions github-actions bot requested a review from ArthurSens December 6, 2024 08:22
@haoqixu haoqixu force-pushed the f-profiles-fileexporter branch from cb30921 to d141a42 Compare December 6, 2024 08:41
@haoqixu haoqixu force-pushed the f-profiles-fileexporter branch from d141a42 to 6475274 Compare December 6, 2024 09:14
@github-actions github-actions bot removed the Stale label Dec 7, 2024
@MovieStoreGuy MovieStoreGuy added ready to merge Code review completed; ready to merge by maintainers waiting-for-code-owners and removed waiting-for-code-owners labels Dec 9, 2024
@andrzej-stencel andrzej-stencel merged commit 94d097a into open-telemetry:main Dec 9, 2024
185 of 187 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 9, 2024
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
…ry#36007)

#### Description
Add support for profiles signal to fileexporter

#### Link to tracking issue
Fixes open-telemetry#35978
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[exporter/file] Add support for profiles signal
5 participants