[pkg/ottl] fix handling of nested maps within slices in flatten function #36204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
github-actions
bot
requested review from
bogdandrutu,
evan-bradley,
kentquirk and
TylerHelmuth
# Conflicts: # pkg/ottl/ottlfuncs/func_flatten.go
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
evan-bradley
approved these changes
Dec 23, 2024
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
TylerHelmuth
approved these changes
Jan 7, 2025
TylerHelmuth
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the behavior of the
flattenfunction to also modify nested objects within slices. Currently WIP, as #36198 should be merged first to avoid too many conflictsLink to tracking issue
Fixes #36162
Testing
Added unit test and adapted e2e tests