[chore]: enable gofumpt linter for pkg #36348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmorel-35
requested review from
dashpole,
a team,
MovieStoreGuy,
andrzej-stencel,
crobert-1,
jpkrohling,
atoulme,
djaglowski,
jmacd,
TylerHelmuth,
bogdandrutu and
evan-bradley
as code owners
github-actions
bot
requested review from
alxbl,
bertysentry,
cparkins,
frzifus and
gouthamve
github-actions
bot
requested review from
JaredTan95,
kentquirk,
mar4uk,
Mrod1598 and
pjanotti
mmorel-35
force-pushed
the
gofumpt/pkg
branch
2 times, most recently
from
191cd18 to
1b94fa5
Compare
|
For housekeeping, @mmorel-35 can you please create an issue for this and mention all the gofumpt pull requests in it, so that those pull requests can be easily correlated? |
| @@ -141,7 +141,7 @@ func testMetrics() pmetric.MetricSlice { | |||
|
|
|||
| dp = dps.AppendEmpty() | |||
| attributes = pcommon.NewMap() | |||
| setDPDoubleVal(dp, 2, attributes, time.Date(1997, 07, 27, 1, 1, 1, 1, &time.Location{})) | |||
| setDPDoubleVal(dp, 2, attributes, time.Date(1997, 0o7, 27, 1, 1, 1, 1, &time.Location{})) | |||
There was a problem hiding this comment.
I like how the formatter has exposed that the "07" is actually interpreted in octal.
andrzej-stencel
approved these changes
Nov 13, 2024
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
mmorel-35
force-pushed
the
gofumpt/pkg
branch
from
1b94fa5 to
79c540a
Compare
9 tasks
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
#### Description [gofumpt](https://golangci-lint.run/usage/linters/#gofumpt) enforces a stricter format than gofmt Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
gofumpt enforces a stricter format than gofmt
Part of #36363