feat: prometheus translation rw2 add support for MetricTypeSum #36353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
reviewed
Nov 14, 2024
| // TODO implement | ||
| dataPoints := metric.Sum().DataPoints() | ||
| if dataPoints.Len() == 0 { | ||
| errs = multierr.Append(errs, fmt.Errorf("empty data points. %s is dropped", metric.Name())) |
There was a problem hiding this comment.
does this need to be returned as an error? Can we just ignore these points instead? addSumNumberDataPoints won't do anything if there are no datapoints
dashpole
reviewed
Nov 14, 2024
| if metric.Sum().IsMonotonic() { | ||
| startTimestamp := pt.StartTimestamp() | ||
| if startTimestamp == 0 { | ||
| return |
There was a problem hiding this comment.
Does this mean the exporter won't be useable with the Prometheus receiver? Often, the prometheus receiver won't have a start timestamp set. Is the created timestamp a strict requirement?
There was a problem hiding this comment.
The created timestamp field is required in the message definition but logically optional as the zero value is acceptable.
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
prometheus translation rw2 add support for MetricTypeSum
TODO:
Link to tracking issue #33661
Fixes
Testing
Documentation