-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Remove unnecessary internal common maps package. #36390
Conversation
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me, great to see code deleted.
Looks like there is at least one problem CI picked up. EDIT: looks like maps.Clone, if passed a nil map, will return a nil map: https://go.dev/play/p/t6VA4ZMC6b7 |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Is this still needed? @bogdandrutu |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
No description provided.