[receiver/azuremonitorreceiver] feat: multi subscriptions support and automatic discovery #36467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
… automatic discovery Signed-off-by: Célian Garcia <celian.garcia@amadeus.com>
6 tasks
atoulme
added a commit
that referenced
this pull request
Mar 21, 2025
… automatic discovery (#37167) Recreated from a diffferent fork. Context: #36467 > <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. > Ex. Adding a feature - Explain what this achieves.--> > #### Description > > This PR allows to discover and scrape all the subscriptions located in the tenant. > I'm adding also at the same time the ability to give multiple subscriptions as it's free and can also be desired. > > This is a part of this PR: #29593 that has been split for readability. > Indeed in a next PR, I'll propose the usage of the getBatch of metrics Azure API. Because if your tenant contains a lot of subscription, you can face rate limitations. > > > It contains also a little refactor of the tests and the "backdoor" used to mock the API. Now the tests are using the way provided by Azure: the fake API. https://github.com/Azure/azure-sdk-for-go/tree/main/sdk/samples/fakes > The "backdoor" is now only the client options. So no weird interfaces nor weird constructor for the Azure clients inside the ``scraper.go`` file. > > <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> > #### Link to tracking issue > Fixes #36612 > > <!--Describe what testing was performed and which tests were added.--> > #### Testing > > <!--Describe the documentation added.--> > #### Documentation > > <!--Please delete paragraphs that you did not use before submitting.--> Thanks to the tests refactoring, closes #31264 (at best it fixes it, at worst this makes it obsolete), relates also #38639 Signed-off-by: Célian Garcia <celian.garcia@amadeus.com> Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com> Co-authored-by: Antoine Toulme <atoulme@splunk.com>
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
… automatic discovery (open-telemetry#37167) Recreated from a diffferent fork. Context: open-telemetry#36467 > <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. > Ex. Adding a feature - Explain what this achieves.--> > #### Description > > This PR allows to discover and scrape all the subscriptions located in the tenant. > I'm adding also at the same time the ability to give multiple subscriptions as it's free and can also be desired. > > This is a part of this PR: open-telemetry#29593 that has been split for readability. > Indeed in a next PR, I'll propose the usage of the getBatch of metrics Azure API. Because if your tenant contains a lot of subscription, you can face rate limitations. > > > It contains also a little refactor of the tests and the "backdoor" used to mock the API. Now the tests are using the way provided by Azure: the fake API. https://github.com/Azure/azure-sdk-for-go/tree/main/sdk/samples/fakes > The "backdoor" is now only the client options. So no weird interfaces nor weird constructor for the Azure clients inside the ``scraper.go`` file. > > <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> > #### Link to tracking issue > Fixes open-telemetry#36612 > > <!--Describe what testing was performed and which tests were added.--> > #### Testing > > <!--Describe the documentation added.--> > #### Documentation > > <!--Please delete paragraphs that you did not use before submitting.--> Thanks to the tests refactoring, closes open-telemetry#31264 (at best it fixes it, at worst this makes it obsolete), relates also open-telemetry#38639 Signed-off-by: Célian Garcia <celian.garcia@amadeus.com> Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com> Co-authored-by: Antoine Toulme <atoulme@splunk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows to discover and scrape all the subscriptions located in the tenant.
I'm adding also at the same time the ability to give multiple subscriptions as it's free and can also be desired.
This is a part of this PR: #29593 that has been split for readability.
Indeed in a next PR, I'll propose the usage of the getBatch of metrics Azure API. Because if your tenant contains a lot of subscription, you can face rate limitations.
It contains also a little refactor of the tests and the "backdoor" used to mock the API. Now the tests are using the way provided by Azure: the fake API. https://github.com/Azure/azure-sdk-for-go/tree/main/sdk/samples/fakes
The "backdoor" is now only the client options. So no weird interfaces nor weird constructor for the Azure clients inside the
scraper.gofile.Link to tracking issue
Fixes #36612
Testing
Documentation