[chore]: [deltatocumulative]: remove nested implementation #36498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Woohoo! Yay for deleting things :) |
RichieSams
approved these changes
Nov 22, 2024
entirely removes the nested (old) implementation of deltatocumulative, as all tests pass using the linear one only.
sh0rez
force-pushed
the
deltatocumulative-only-linear
branch
from
25f9626 to
f2837e7
Compare
jpkrohling
approved these changes
Dec 3, 2024
shivanthzen
pushed a commit
to shivanthzen/opentelemetry-collector-contrib
that referenced
this pull request
Dec 5, 2024
…metry#36498) #### Description Removes the nested (aka overloading `streams.Map`) implementation. This has been entirely replaced by a leaner, "linear" implementation: - open-telemetry#35048 - open-telemetry#36486 <!--Describe what testing was performed and which tests were added.--> #### Testing Existing tests continue to pass unaltered <!--Describe the documentation added.--> #### Documentation not needed <!--Please delete paragraphs that you did not use before submitting.-->
ZenoCC-Peng
pushed a commit
to ZenoCC-Peng/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2024
…metry#36498) #### Description Removes the nested (aka overloading `streams.Map`) implementation. This has been entirely replaced by a leaner, "linear" implementation: - open-telemetry#35048 - open-telemetry#36486 <!--Describe what testing was performed and which tests were added.--> #### Testing Existing tests continue to pass unaltered <!--Describe the documentation added.--> #### Documentation not needed <!--Please delete paragraphs that you did not use before submitting.-->
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
…metry#36498) #### Description Removes the nested (aka overloading `streams.Map`) implementation. This has been entirely replaced by a leaner, "linear" implementation: - open-telemetry#35048 - open-telemetry#36486 <!--Describe what testing was performed and which tests were added.--> #### Testing Existing tests continue to pass unaltered <!--Describe the documentation added.--> #### Documentation not needed <!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the nested (aka overloading
streams.Map) implementation.This has been entirely replaced by a leaner, "linear" implementation:
Testing
Existing tests continue to pass unaltered
Documentation
not needed