-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/receiver_creator] Add support for enabling logs' collecting from K8s hints #36581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrsMark
force-pushed
the
f_hints_logs
branch
9 times, most recently
from
November 29, 2024 09:52
318793e
to
330fee3
Compare
dmitryax
reviewed
Nov 30, 2024
ChrsMark
force-pushed
the
f_hints_logs
branch
5 times, most recently
from
December 10, 2024 08:55
3e5b659
to
9a21436
Compare
@dmitryax I have removed the default logs collection option. Feel free to take a look. |
ChrsMark
force-pushed
the
f_hints_logs
branch
from
December 10, 2024 09:10
9a21436
to
f04b3f1
Compare
dmitryax
reviewed
Dec 17, 2024
ChrsMark
force-pushed
the
f_hints_logs
branch
2 times, most recently
from
December 18, 2024 18:52
17d4adb
to
1dd06ec
Compare
dmitryax
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with couple nits
ChrsMark
force-pushed
the
f_hints_logs
branch
from
December 20, 2024 11:25
28c8256
to
e18fe60
Compare
@dmitryax your comments should be addressed now. Anything else missing? |
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
dmitryax
approved these changes
Jan 7, 2025
TylerHelmuth
pushed a commit
that referenced
this pull request
Jan 9, 2025
…6910) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PR replace positional arguements with named in struct initialization. Addresses #36581 (comment) Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the logs part for #34427 based on the design decided at #34427 (comment).
See the README docs for the description of this feature: https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/35617/files#diff-4127365c4062a7510fb7fede0fa239e9232549732898303d94c12fef0433d39d
Link to tracking issue
Fixes #34427
Testing
Added unit-tests
Documentation
Added README section
How to test this manually
Follow-ups