Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sqlqueryreceiver] Fix accidental removal of integration test tag for sqlqueryreceiver tests #36923

Merged

Conversation

dehaansa
Copy link
Contributor

Description

Accidentally committed this in #36812 when I had removed it for some local testing.

Link to tracking issue

Fixes #36917

@dehaansa
Copy link
Contributor Author

/label skip-changelog

@dehaansa
Copy link
Contributor Author

/label skip-changelog

I didn't think I had permissions for this, but figured I would try. I don't believe this should have a changelog entry!

@songy23 songy23 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Dec 23, 2024
@songy23 songy23 added Run Windows Enable running windows test on a PR flaky test a test is flaky os:windows labels Dec 23, 2024
@songy23
Copy link
Member

songy23 commented Jan 6, 2025

Test failure is unrelated to this PR #10151

@songy23 songy23 added the ready to merge Code review completed; ready to merge by maintainers label Jan 6, 2025
@pjanotti
Copy link
Contributor

pjanotti commented Jan 6, 2025

This will likely hit the issue fixed by #37036 (unless that one is merged before).

@dmitryax dmitryax merged commit 09b6d77 into open-telemetry:main Jan 6, 2025
176 of 177 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 6, 2025
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.61%. Comparing base (333f016) to head (3ffeb06).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #36923      +/-   ##
==========================================
- Coverage   79.63%   79.61%   -0.03%     
==========================================
  Files        2223     2223              
  Lines      210283   210283              
==========================================
- Hits       167467   167418      -49     
- Misses      37206    37248      +42     
- Partials     5610     5617       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dehaansa dehaansa deleted the fix/sqlqueryreceiver-integration-test branch January 6, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky test a test is flaky os:windows ready to merge Code review completed; ready to merge by maintainers receiver/sqlquery SQL query receiver Run Windows Enable running windows test on a PR Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Broken test] [sqlqueryreceiver] several tests keep failing on Windows
6 participants