Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/sqlserver] Add SQL server host resource attributes #37004

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

LZiHaN
Copy link
Contributor

@LZiHaN LZiHaN commented Jan 1, 2025

Description

The new attribute are added to the SQL server receiver to distinguish metrics coming from different SQL server instances.

  • server.address: The address of the SQL server host, enabled by default.
  • server.port: The port of the SQL server host, disabled by default.

Link to tracking issue

refer to #35183

Testing

passes tests.

Documentation

no need to update.

Copy link
Contributor

@fatsheep9146 fatsheep9146 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a conflict need to be resolved, please help fix it, thanks!

@LZiHaN LZiHaN force-pushed the sqlserver-add-address-resource-attr branch from 2c367a8 to e2fb7a5 Compare January 18, 2025 10:24
@LZiHaN
Copy link
Contributor Author

LZiHaN commented Jan 18, 2025

There is a conflict need to be resolved, please help fix it, thanks!

hi, I’ve resolved the merge conflicts, but I noticed that the actions workflow is failing with a check-links error. I’m not entirely sure what this error refers to. could someone provide more details or guidance on how to address this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants