[elasticsearchexporter] Support for complex attributes for log records in OTel mode #37021
Conversation
According to the spec: The log attribute model MUST support any type, a superset of standard Attribute, to preserve the semantics of structured attributes emitted by the applications. This field is optional.
|
|
||
| logs := plog.NewLogs() | ||
| resourceLog := logs.ResourceLogs().AppendEmpty() | ||
| resourceLog.Resource().Attributes().PutEmptyMap("some.resource.attribute").PutEmptyMap("foo").PutStr("bar", "baz") |
There was a problem hiding this comment.
While this kinda works, there are some limitations due to the way obj model gets serialized and de-dotted in OTel mode. The test would fail if, for example changing to
resourceLog.Resource().Attributes().PutEmptyMap("some.resource.attribute").PutEmptyMap("foo.bar").PutStr("bar", "baz")
I think we should merge the change despite this limitation but think about longer-term alternatives.
I'm currently doing a POC of serializing pdata events directly to JSON for the OTel mode, without first converting them do an objmodel.Document. This seems to work out quite well so far and I'd also suspect it to yield performance improvements due to one less layer of abstraction and avoiding the allocation of temporary objects. WDYT of that approach?
There was a problem hiding this comment.
Here's the draft PR for that POC: #37032
… mode (#37032) Directly serializes pdata to JSON in OTel mode * Improved performance as no `objmodel.Document` needs to be created first * Fixes issue discovered in #37021 where map bodies with dotted field names are de-dotted --------- Co-authored-by: Carson Ip <carsonip@users.noreply.github.com> Co-authored-by: Christos Markou <chrismarkou92@gmail.com>
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closing as superseded by #37032 |
According to the spec: