Skip to content

receiver/awsfirehosereceiver: optimise cwlogs unmarshaler #37111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

axw
Copy link
Contributor

@axw axw commented Jan 9, 2025

Description

Avoid allocating intermediate byte slices for decompressing and iterating through newline-delimited JSON.

Link to tracking issue

N/A

Testing

Non-functional change, run the unit tests.
Added a new microbenchmark for the unmarshaler in question.

Documentation

N/A

@github-actions github-actions bot requested a review from Aneurysm9 January 9, 2025 08:23
@axw axw force-pushed the awsfirehosereceiver-cwlogs-opt branch from 060b41d to c254d95 Compare January 9, 2025 08:23
@axw axw changed the title receiver/awwsfirehosereceiver: optimise cwlogs unmarshaler receiver/awsfirehosereceiver: optimise cwlogs unmarshaler Jan 9, 2025
@axw axw marked this pull request as ready for review January 9, 2025 09:19
@axw axw requested a review from a team as a code owner January 9, 2025 09:19
@axw axw requested a review from songy23 January 9, 2025 09:19
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jan 24, 2025
@github-actions github-actions bot removed the Stale label Jan 29, 2025
@axw
Copy link
Contributor Author

axw commented Feb 10, 2025

Superseded by #37361

@axw axw closed this Feb 10, 2025
atoulme pushed a commit that referenced this pull request Mar 11, 2025
#### Description

I would like to become a codeowner of the awsfirehosereceiver. Elastic
(where I work) intends to use this receiver heavily, and I would like
to:
 - help spread out the maintenance load
- ensure we have a path to progressing beyond the current Alpha
stability

Assuming
open-telemetry/opentelemetry-collector#11864
goes through, it will be necessary to have multiple codeowners to
progress to Beta and preferable to have codeowners from multiple
employers, which is the case for @Aneurysm9 (AWS) and me (Elastic).

Relevant changes:
-
#37111
(superseded by #37361)
-
#37262
-
#37361
-
#38388
(will extract from awsfirehosereceiver)
-
#38445

#### Link to tracking issue

N/A

#### Testing

N/A

#### Documentation

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants