[exporter/clickhouse] Add client info for identifying exporter in system.query_log
#37146
+150
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
not stale 👉 |
dmitryax
reviewed
Jan 25, 2025
| resolver.version = "unknown-" + osInformation | ||
|
|
||
| info, ok := debug.ReadBuildInfo() | ||
| if ok && info.Main.Version != "" { |
There was a problem hiding this comment.
Why don't use the collector version passed the factory as part of exporter.Settings.BuildInfo.Version?
There was a problem hiding this comment.
There was some discussion in the old PR on where to get this version info from. I can swap this out. Not sure what the string looks like, or what it may appear as during tests, but it seems simpler than the current implementation. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
(reopen from #34915)
This change will include information about the collector version and OS/Arch for every
INSERT. Users can then track the origin of these queries insystem.query_log. For an official build this will look something likeotelcol/v0.114.0-lin-amd64.This is implemented by setting
client_info_productin the DSN. The underlying ClickHouse Go driver will then attach it upon connection. Users can already add their own version info inendpointorconnection_params, but this change will now safely set or append to that value with the binary's information.Documentation:
client_product_infoTesting: