Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] fix code owners #37291

Merged
merged 2 commits into from
Jan 17, 2025
Merged

[chore] fix code owners #37291

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d44c88
[chore] fix code owners
songy23 Jan 17, 2025
1f3c0ad
[chore] fix code owners
songy23 Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,8 +324,8 @@ reports/distributions/k8s.yaml @open-telemetry/collector-contrib-approvers

## UNMAINTAINED components

exporter/kineticaexporter/ @open-telemetry/collector-contrib-approvers
exporter/opensearchexporter/ @open-telemetry/collector-contrib-approvers
extension/observer/ecstaskobserver/ @open-telemetry/collector-contrib-approvers
extension/storage/filestorage/ @open-telemetry/collector-contrib-approvers
receiver/jmxreceiver/ @open-telemetry/collector-contrib-approvers
exporter/kineticaexporter/ @open-telemetry/collector-contrib-approvers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is extra whitespace being added here? I assume it's to fix CI?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, without the whitespace CI failed: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/12832998175/job/35787022502

(it's really hard to tell unless you select and highlight those diffs)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with merging this now to fix CI, I realize it's time sensitive, but it seems like the real solution here is to fix githubgen to not add whitespace after these lines. I assume removing the trailing whitespace before \n should fix it?

opentelemetry-collector-contrib/cmd/githubgen/codeowners.go

Line 142 in 3febf16

unmaintainedCodeowners += fmt.Sprintf("%s/%s @open-telemetry/collector-contrib-approvers \n", key, strings.Repeat(" ", data.maxLength-len(key)))

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 created #37292 to follow up, will merge this PR to fix mainline for now

exporter/opensearchexporter/ @open-telemetry/collector-contrib-approvers
extension/observer/ecstaskobserver/ @open-telemetry/collector-contrib-approvers
extension/storage/filestorage/ @open-telemetry/collector-contrib-approvers
receiver/jmxreceiver/ @open-telemetry/collector-contrib-approvers
Loading