Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] detect gnu-sed #37306

Merged
merged 3 commits into from
Jan 22, 2025
Merged

[chore] detect gnu-sed #37306

merged 3 commits into from
Jan 22, 2025

Conversation

zirain
Copy link
Contributor

@zirain zirain commented Jan 18, 2025

Description

make check-collector-module-version.sh worked on macos with gnu-sed.

Link to tracking issue

Fixes #37304

Testing

Documentation

@zirain zirain requested a review from a team as a code owner January 18, 2025 09:06
@zirain zirain requested a review from ChrsMark January 18, 2025 09:06
@zirain zirain changed the title detect gnu-sed [chore] detect gnu-sed Jan 18, 2025
atoulme
atoulme approved these changes Jan 19, 2025
View reviewed changes
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the fix

@songy23 songy23 added the ci-cd CI, CD, testing, build issues label Jan 20, 2025
@atoulme atoulme added the ready to merge Code review completed; ready to merge by maintainers label Jan 21, 2025
@MovieStoreGuy MovieStoreGuy added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 21, 2025
@MovieStoreGuy MovieStoreGuy merged commit 8034e0d into open-telemetry:main Jan 22, 2025
164 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 22, 2025
@zirain zirain deleted the detected-sed branch January 22, 2025 00:26
chengchuanpeng pushed a commit to chengchuanpeng/opentelemetry-collector-contrib that referenced this pull request Jan 26, 2025
@zirain @MovieStoreGuy @chengchuanpeng
[chore] detect gnu-sed (open-telemetry#37306)
bb19c15 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

make `check-collector-module-version.sh` worked on macos with gnu-sed.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes
open-telemetry#37304

<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->
#### Documentation

<!--Please delete paragraphs that you did not use before submitting.-->

Co-authored-by: Sean Marciniak <30928402+MovieStoreGuy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MovieStoreGuy MovieStoreGuy MovieStoreGuy approved these changes

@atoulme atoulme atoulme approved these changes

@ChrsMark ChrsMark Awaiting requested review from ChrsMark ChrsMark is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

Assignees

@MovieStoreGuy MovieStoreGuy

Labels
ci-cd CI, CD, testing, build issues ready to merge Code review completed; ready to merge by maintainers Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
next release
Development

Successfully merging this pull request may close these issues.

check-collector-module-version.sh failed on macos if using gnu-sed
4 participants
@zirain @atoulme @MovieStoreGuy @songy23