[exporter/prometheusremotewrite] change feature gate to stable #37399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
ArthurSens,
bertysentry and
dashpole
dashpole
approved these changes
Jan 22, 2025
ChrsMark
approved these changes
Jan 22, 2025
songy23
reviewed
Jan 22, 2025
| @@ -44,7 +44,7 @@ const ( | |||
|
|
|||
| var exportCreatedMetricGate = featuregate.GlobalRegistry().MustRegister( | |||
There was a problem hiding this comment.
panic: no removal version set for Stable gate "exporter.prometheusremotewriteexporter.deprecateCreatedMetric"
There was a problem hiding this comment.
uhmm.
build-and-test / integration-tests-matrix (pkg) (pull_request)Failing after 3m
"exporter.prometheusremotewriteexporter.deprecateCreatedMetric" is stable, can not be disabled
Taking a look...
…ebaj/opentelemetry-collector-contrib into deprecate-created-metric-beta2stable
|
There are some tests that need to be removed, since the featuregate can't be disabled now |
I think that I removed the right ones a168f9e |
songy23
reviewed
Jan 23, 2025
| # Use this changelog template to create an entry for release notes. | ||
|
|
||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
| change_type: deprecation |
There was a problem hiding this comment.
Indeed this is a breaking change
| @@ -704,7 +704,7 @@ func TestPrometheusConverter_AddSummaryDataPoints(t *testing.T) { | |||
| }{ | |||
| { | |||
| name: "summary with start time", | |||
| isGateEnabled: false, | |||
| isGateEnabled: true, | |||
There was a problem hiding this comment.
I think this isGateEnabled can simply be removed everywhere
songy23
approved these changes
Jan 24, 2025
chengchuanpeng
pushed a commit
to chengchuanpeng/opentelemetry-collector-contrib
that referenced
this pull request
Jan 26, 2025
…telemetry#37399) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description * Change `exporter.prometheusremotewriteexporter.deprecateCreatedMetric`feature gate from Beta to Stable * Adapt some test cases that were considering this feature as disable <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue open-telemetry#35003
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
exporter.prometheusremotewriteexporter.deprecateCreatedMetricfeature gate from Beta to StableLink to tracking issue
#35003