Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add STEF exporter #37400

Merged
merged 6 commits into from
Jan 22, 2025
Merged

Conversation

tigrannajaryan
Copy link
Member

Resolves #37352

This is the First PR done according to the requirements listed at https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#adding-new-components

I intentionally left the Config barebones. It is possible we will add more config options in the future but I don't want to do it prematurely.

Subsequent PRs will add the implementation and will clarify how it works in the README.md.

@tigrannajaryan tigrannajaryan requested a review from a team as a code owner January 22, 2025 00:11
@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 22, 2025
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor comments. Otherwise, LGTM

exporter/stefexporter/metadata.yaml Outdated Show resolved Hide resolved
exporter/stefexporter/factory.go Outdated Show resolved Hide resolved
Resolves open-telemetry#37352

This is the *First PR* done according to the requirements listed at https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#adding-new-components

I intentionally left the Config barebones. It is possible we will add more config
options in the future but I don't want to do it prematurely.

Subsequent PRs will add the implementation and will clarify how it works in the README.md.
@tigrannajaryan
Copy link
Member Author

@dmitryax I addressed your comments.

The "Gen CODEOWNERS" github action errors with "2025/01/22 21:42:15 codeowners members duplicate in allowlist: jerrytfleung". Any idea what this is about? I can only see one "jerrytfleung" allowlist.txt, not sure what the duplicate is about. Unclear how my change is related to this error.

@atoulme since you are listed as a codeowner of githubgen, any idea what the error message is trying to tell me? Running githubgen --skipgithub locally does not give any errors (I don't have a PAT to try without --skipgithub).

@atoulme
Copy link
Contributor

atoulme commented Jan 22, 2025

@tigrannajaryan the issue reported is unrelated to your PR. A member of the allowlist has become an official member of OpenTelemetry and should be removed from the allowlist.

2025/01/22 21:42:15 codeowners members duplicate in allowlist: jerrytfleung
I will open a PR to fix. Thanks for reaching out.

@tigrannajaryan
Copy link
Member Author

Thanks @atoulme
Please let me know once it is fixed, I will rebase.

@atoulme
Copy link
Contributor

atoulme commented Jan 22, 2025

You will not need to rebase for this, but I can trigger a rerun. The check-codeowners job runs by checking out the main branch of the repository. The fix is here: #37423

I will let you know of what this comes to in any case.

@atoulme
Copy link
Contributor

atoulme commented Jan 22, 2025

Alright, the pull_request_target is still pointing at the old main branch, so you'll need to rebase @tigrannajaryan. If you don't get around to it, I have updated with latest main here.

@dmitryax dmitryax merged commit 23117ab into open-telemetry:main Jan 22, 2025
164 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 22, 2025
@tigrannajaryan
Copy link
Member Author

Thanks @dmitryax @atoulme !

@tigrannajaryan tigrannajaryan deleted the tigran/stefexporter branch January 23, 2025 00:30
chengchuanpeng pushed a commit to chengchuanpeng/opentelemetry-collector-contrib that referenced this pull request Jan 26, 2025
Resolves
open-telemetry#37352

This is the *First PR* done according to the requirements listed at
https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#adding-new-components

I intentionally left the Config barebones. It is possible we will add
more config options in the future but I don't want to do it prematurely.

Subsequent PRs will add the implementation and will clarify how it works
in the README.md.

---------

Co-authored-by: Antoine Toulme <atoulme@splunk.com>
Co-authored-by: Dmitry Anoshin <anoshindx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reports/distributions/contrib.yaml Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New component: STEF exporter
4 participants