-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add STEF exporter #37400
Add STEF exporter #37400
Conversation
373b349
to
ede0941
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor comments. Otherwise, LGTM
Resolves open-telemetry#37352 This is the *First PR* done according to the requirements listed at https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#adding-new-components I intentionally left the Config barebones. It is possible we will add more config options in the future but I don't want to do it prematurely. Subsequent PRs will add the implementation and will clarify how it works in the README.md.
c59e346
to
ab5a0fb
Compare
@dmitryax I addressed your comments. The "Gen CODEOWNERS" github action errors with "2025/01/22 21:42:15 codeowners members duplicate in allowlist: jerrytfleung". Any idea what this is about? I can only see one "jerrytfleung" allowlist.txt, not sure what the duplicate is about. Unclear how my change is related to this error. @atoulme since you are listed as a codeowner of githubgen, any idea what the error message is trying to tell me? Running |
@tigrannajaryan the issue reported is unrelated to your PR. A member of the allowlist has become an official member of OpenTelemetry and should be removed from the allowlist.
|
Thanks @atoulme |
You will not need to rebase for this, but I can trigger a rerun. The check-codeowners job runs by checking out the main branch of the repository. The fix is here: #37423 I will let you know of what this comes to in any case. |
Alright, the |
Resolves open-telemetry#37352 This is the *First PR* done according to the requirements listed at https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#adding-new-components I intentionally left the Config barebones. It is possible we will add more config options in the future but I don't want to do it prematurely. Subsequent PRs will add the implementation and will clarify how it works in the README.md. --------- Co-authored-by: Antoine Toulme <atoulme@splunk.com> Co-authored-by: Dmitry Anoshin <anoshindx@gmail.com>
Resolves #37352
This is the First PR done according to the requirements listed at https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#adding-new-components
I intentionally left the Config barebones. It is possible we will add more config options in the future but I don't want to do it prematurely.
Subsequent PRs will add the implementation and will clarify how it works in the README.md.