-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[processor/transform] Add support for flat configuration style #37444
Merged
evan-bradley
merged 6 commits into
open-telemetry:main
from
edmocosta:add-config-flat-statements-support
Feb 3, 2025
Merged
[processor/transform] Add support for flat configuration style #37444
evan-bradley
merged 6 commits into
open-telemetry:main
from
edmocosta:add-config-flat-statements-support
Feb 3, 2025
+792
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bogdandrutu,
evan-bradley,
kentquirk and
TylerHelmuth
January 23, 2025 14:28
edmocosta
commented
Jan 23, 2025
TylerHelmuth
approved these changes
Feb 3, 2025
@evan-bradley please review |
evan-bradley
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the long delay. The way we're handling the config makes sense to me.
processor/transformprocessor/internal/metrics/processor_test.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is part of #29017, and a split from #36888. It changes the
transformprocessor
, adding support for flat configuration styles.Change log:
cache
values are only shared among flat statementscache
values are still isolated, which means that a cache written using a structured configuration style will only be available for that configuration group's statements, and won't be shared with flat statements and/or other structured configuration groups, for example:Link to tracking issue
#29017
Testing
Unit tests